Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm v8 support #44

Merged
merged 9 commits into from
Jun 1, 2022
Merged

npm v8 support #44

merged 9 commits into from
Jun 1, 2022

Conversation

yorickvP
Copy link
Contributor

Fixes #33

  • Added CI with tests for npm v6, npm v8 and yarn
  • Also rewrite new package-lock.json format
  • Add a check for unsupported package-lock.json format
  • Add a passthru.nodeModules attribute, very useful for debugging
  • Persist the cache in the nodeModules drv. This is kindof ugly, but npm prune sometimes installs packages now :(.

@gromakovsky please forward this for review to whoever is using this internally

@yorickvP yorickvP requested a review from balsoft May 31, 2022 16:32
@yorickvP yorickvP changed the title Yorickvp/npm v8 npm v8 support May 31, 2022
@balsoft
Copy link
Member

balsoft commented Jun 1, 2022

Maybe also remove the travis badge from README

@yorickvP
Copy link
Contributor Author

yorickvP commented Jun 1, 2022

Just pushed some changes that greatly simplify the cache building (it no longer has to rewrite the lockfile).

Also submitted npm/cacache#114 to be more efficient about putting the npm cache in the nix store.

Copy link
Member

@balsoft balsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty clean, and seems to work! I like it

@balsoft balsoft merged commit bfca646 into master Jun 1, 2022
@balsoft balsoft deleted the yorickvp/npm-v8 branch June 1, 2022 09:52
@gromakovsky
Copy link
Member

We'll test it in our project, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken on npm v7
3 participants