-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PHP 8 support; dropped Travis and Coveralls; use Github Actions from now on #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change, each phpunit run generated a coverage report, which is time consuming and not neccessary. now it should be faster because the report is only generated once. extended composer.json with script section for commands run in Travis.
Pull Request Test Coverage Report for Build 132
💛 - Coveralls |
* only CLI, no Apache webserver anymore * default is PHP 8.0
@semsol I finished this PR, can you have a (short) look please? Thanks in advance. |
it fails because it didnt use the dynamic port from DB_PORT yet.
I updated my initial post. Github Actions result can be found here: https://github.com/semsol/arc2/actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was about Travis and Code Coverage originally.
But Travis was extremely slow when running ARC2 tests and it took hours before one of the tests even started (December 3th and 4th 2020). It was new to me. To be more independent from other services as well as get faster test results I abandoned Travis as well as Coveralls support.
Also added PHP 8 support.