Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of lines scanned is ridiculously wrong #100

Closed
mcpeak opened this issue Dec 2, 2016 · 1 comment
Closed

Number of lines scanned is ridiculously wrong #100

mcpeak opened this issue Dec 2, 2016 · 1 comment
Assignees
@gcmurphy

Comments

@mcpeak
Copy link

mcpeak commented Dec 2, 2016

I've run a scan against a repo with about 300K lines of Go code and the resulting "lines of code scanned" at the end is in the 16 billion range. This is obviously pretty far off.
@gcmurphy
Copy link
Member

gcmurphy commented Dec 2, 2016 •
edited
Loading

Doesn't look the stats are being initialized properly so using garbage memory

Actually need to reset fset between each file processed..

@gcmurphy gcmurphy self-assigned this Dec 2, 2016
gcmurphy added a commit that referenced this issue Dec 2, 2016
@gcmurphy
Recreate fileset each time we process a file
191750f 
Some files were being counted multiple times here and giving a skewed
result for line numbers processed.

Closes #100
@gcmurphy gcmurphy mentioned this issue Dec 2, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcmurphy gcmurphy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gcmurphy @mcpeak