Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install from the specified release channel #9

Merged
merged 2 commits into from
Nov 8, 2017

Conversation

kumada626
Copy link
Contributor

Context

Habitat packages have release channel, and hab pkg install command install packages from default channel stable.
However, the method PackageVersionsFromName returns specified name packages in all release channel. Therefore, if a package whose version is matched pkgVersionExp is not in stable channel, sd_step failed like below.
2017-11-07 14 14 46

Objective

  • Add an option hab-channel to install habitat packages from specified release channel.
  • Fix PackageVersionsFromName to search package versions from specified release channel.

References

An example of habitat's response:
https://willem.habitat.sh/v1/depot/pkgs/core/node?range=0
hab pkg install reference:
https://www.habitat.sh/docs/habitat-cli/#hab-pkg-install

@ghost ghost assigned kumada626 Nov 7, 2017
@ghost ghost added the status/verify label Nov 7, 2017
@tkyi
Copy link
Member

tkyi commented Nov 7, 2017

Looks good to me
Can you add a README at some point?

@kumada626
Copy link
Contributor Author

Added a README.

Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tkyi tkyi merged commit a47692a into screwdriver-cd:master Nov 8, 2017
@ghost ghost removed the status/verify label Nov 8, 2017
@kumada626 kumada626 deleted the enable_channel_option branch November 8, 2017 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants