Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1007): Add getLinks method #2

Merged
merged 2 commits into from
May 8, 2018
Merged

fix(1007): Add getLinks method #2

merged 2 commits into from
May 8, 2018

Conversation

tkyi
Copy link
Member

@tkyi tkyi commented May 8, 2018

Context

Users would like to get a link to their badge and how to get to the project.

Objective

This PR adds a method getLinks to return badge and project links.

Related links

Related to screwdriver-cd/screwdriver#1007
Blocked by screwdriver-cd/coverage-base#6

@@ -15,6 +15,9 @@ npm install screwdriver-screwdriver-coverage-sonar
npm test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiff, can you also update build links etc. in the readme? I forgot to do it last time. Otherwise LGTM 👍

Copy link
Member

@jithine jithine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 have the build pass before merging.

@tkyi tkyi merged commit 784df9d into master May 8, 2018
@tkyi tkyi deleted the links branch May 8, 2018 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants