Imports: if expanding only, do not group imports

scalameta · Sep 2, 2021 · a30075c · a30075c
1 parent 24a6a87
commit a30075c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/Imports.scala b/scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/Imports.scala
@@ -473,7 +473,10 @@ object Imports extends RewriteFactory {
     override protected def processImports(
         stats: Seq[Seq[ImportExportStat]]
     ): Unit =
-      processAllGroups(stats)
+      if (settings.groups.isEmpty && settings.sort.eq(Sort.none))
+        processEachLine(stats)
+      else
+        processAllGroups(stats)
 
     private def getTokenRange(x: Seq[ImportExportStat]): (Token, Token) = {
       val headTok = x.head.tokens.head
@@ -484,6 +487,13 @@ object Imports extends RewriteFactory {
       )
     }
 
+    private def processEachLine(stats: Seq[Seq[ImportExportStat]]): Unit =
+      stats.flatten.foreach { stat =>
+        val group = Seq(stat)
+        val importString = processImports(group)
+        processTokenRanges(importString, getTokenRange(group))
+      }
+
     private def processAllGroups(stats: Seq[Seq[ImportExportStat]]): Unit = {
       val tokenRanges = stats.map(getTokenRange)
       val importString = processImports(stats.flatten)

diff --git a/scalafmt-tests/src/test/resources/rewrite/ExpandImportSelectors.stat b/scalafmt-tests/src/test/resources/rewrite/ExpandImportSelectors.stat
@@ -137,4 +137,7 @@ import zio.prelude.` => `
 import zio.prelude.{<=>, ` => `}
 >>>
 import zio.prelude.<=>
+
+import zio.prelude.` => `
+import zio.prelude.<=>
 import zio.prelude.` => `
diff --git a/scalafmt-tests/src/test/resources/rewrite/Imports.source b/scalafmt-tests/src/test/resources/rewrite/Imports.source
@@ -57,6 +57,7 @@ import h.k
 import h.l
 export d.e.f
 export d.e.g
+
 // comment
 import a.md.e.f
 import a.md.e.g
@@ -676,6 +677,7 @@ import bar.b
 import bar.a
 >>>
 import bar.b
+
 import bar.a
 <<< #2720 !expand
 rewrite.imports.expand = false