Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly build failure + Address issue with the self-hosted runner #19720

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Feb 17, 2024

Closes #19712

This PR introduce a workaround for actions/runner#2033. This workaround was already introduced in #19703 in some of the jobs.

actions/checkout has an issue filled about this too: actions/checkout#1169

@@ -69,7 +69,9 @@ jobs:
run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH

- name: Reset existing repo
run: git -c "http.https://github.com/.extraheader=" fetch --recurse-submodules=no "https://github.com/lampepfl/dotty" && git reset --hard FETCH_HEAD || true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The true at the end made the CI pass when it should have failed (See https://github.com/lampepfl/dotty/actions/runs/7924243033/job/21635455423?pr=19703). Should we remove it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it in another PR, see if I can remove the reset too.

@hamzaremmal
Copy link
Member Author

I've added git config --global --add safe.directory /__w/dotty/dotty before each call to a git command as a workaround for the mentioned issue above.

@hamzaremmal hamzaremmal requested a review from smarter February 17, 2024 20:42
@hamzaremmal hamzaremmal changed the title Fix nightly build failure Fix nightly build failure + Address issue with the self-hosted runner Feb 17, 2024
@hamzaremmal
Copy link
Member Author

hamzaremmal commented Feb 17, 2024

Also, I believe that the issue didn't manifest earlier (and worse) since the workflow "reset" the repository, then runs the actions/checkout action; which then delete the content of the previous reset. Why are we reseting in that case ? Can we just do the checkout step without reseting the repository ?

@smarter
Copy link
Member

smarter commented Feb 17, 2024

I think this was to workaround issues with the repository getting stuck in a bad state with submodules, but it might not be necessary anymore as actions/checkout should now be more robust.

@hamzaremmal
Copy link
Member Author

I'll wait for the CI to finish the run and check if we don't have any other silent failure before merging it

@hamzaremmal hamzaremmal merged commit 6a795fd into scala:main Feb 17, 2024
19 checks passed
@hamzaremmal hamzaremmal deleted the i19712 branch February 17, 2024 22:51
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2024-02-17 failed
3 participants