-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly build failure + Address issue with the self-hosted runner #19720
Conversation
@@ -69,7 +69,9 @@ jobs: | |||
run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH | |||
|
|||
- name: Reset existing repo | |||
run: git -c "http.https://github.com/.extraheader=" fetch --recurse-submodules=no "https://github.com/lampepfl/dotty" && git reset --hard FETCH_HEAD || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The true
at the end made the CI pass when it should have failed (See https://github.com/lampepfl/dotty/actions/runs/7924243033/job/21635455423?pr=19703). Should we remove it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it in another PR, see if I can remove the reset too.
I've added |
Also, I believe that the issue didn't manifest earlier (and worse) since the workflow "reset" the repository, then runs the |
I think this was to workaround issues with the repository getting stuck in a bad state with submodules, but it might not be necessary anymore as actions/checkout should now be more robust. |
I'll wait for the CI to finish the run and check if we don't have any other silent failure before merging it |
Closes #19712
This PR introduce a workaround for actions/runner#2033. This workaround was already introduced in #19703 in some of the jobs.
actions/checkout
has an issue filled about this too: actions/checkout#1169