Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec] remove implementation details from enum spec #18579

Merged
merged 2 commits into from
Sep 22, 2023
Merged

[spec] remove implementation details from enum spec #18579

merged 2 commits into from
Sep 22, 2023

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented Sep 21, 2023 •
edited
Loading

  • remove details that force all explicit extends clauses to have unique anonymous classes. Perhaps we can find a way in the future to desugar explicit extends clauses to the same implementation class
  • also cleanup definitions of rules

@bishabosha bishabosha requested a review from sjrd September 21, 2023 14:51
sjrd
sjrd requested changes Sep 21, 2023
View reviewed changes
docs/_spec/05-classes-and-objects.md
```scala
case ´C_1´; ...; case ´C_n´
```
Any modifiers or annotations on the original case extend to all expanded cases.
This result is then further rewritten by either (3 or 4).
<p>This result is then further rewritten by either (3 or 4).</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that actually render in a meaningful way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it looks nicer with the clean break, there's no way to do that in pure markdown without breaking the numbered list

@bishabosha bishabosha requested a review from sjrd September 22, 2023 10:00
@bishabosha
Copy link
Member Author

@sjrd addressed the comments, we should probably review individual definition words, such as "enum class" and "unparameterized" later, as these seem to cause confusion unless you pay attention to every detail

@sjrd sjrd enabled auto-merge September 22, 2023 10:15
@sjrd sjrd merged commit 920c288 into scala:main Sep 22, 2023
@sjrd sjrd deleted the update-spec-enums branch September 22, 2023 11:18
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "[spec] remove implementation details from enum spec" to LTS (…
e54ed3e 
…#20619)

Backports #18579 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Jun 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "[spec] remove implementation details from enum spec" to LTS (…
4827cc7 
…#20677)

Backports #18579 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bishabosha @sjrd @Kordyjan