Skip to content

Move {. => dom}/src #571

Closed
Closed
@japgolly

Description

@japgolly
Contributor

Currently the root project is .root and dom is .. It should be . and dom respectively.

Activity

added this to the v2.0.0 milestone on Sep 6, 2021
self-assigned this
on Sep 6, 2021
japgolly

japgolly commented on Oct 17, 2021

@japgolly
ContributorAuthor

Doesn't matter, fine as is

japgolly

japgolly commented on Oct 18, 2021

@japgolly
ContributorAuthor

Actually I should do this.

  1. Makes the project consistent within itself, and with most other projects
  2. A user who opens sbt and runs test would be surprised to find that there are other modules whose tests didn't run
japgolly

japgolly commented on Oct 20, 2021

@japgolly
ContributorAuthor

I'll do this quickly now while the PR queue is empty

added a commit that references this issue on Oct 20, 2021
44ff6b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @japgolly

    Issue actions

      Move `{. => dom}/src` · Issue #571 · scala-js/scala-js-dom