Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use read buffer to reduce read syscall #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions buffer.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
package uuid

import (
"io"
"sync/atomic"
"unsafe"
)

type buffer struct {
data []byte
readPos int64
}

type bytesBuffer struct {
bufferPointer unsafe.Pointer
bufferSize int
status uint32
src io.Reader
}

func newBytesBuffer(bufferSize int, src io.Reader) *bytesBuffer {
if bufferSize <= 0 || src == nil {
return nil
}
return &bytesBuffer{
bufferSize: bufferSize,
bufferPointer: unsafe.Pointer(&buffer{}),
src: src,
}
}

func (bb *bytesBuffer) reset(p []byte) {
atomic.StorePointer(&bb.bufferPointer, unsafe.Pointer(&buffer{
data: p,
readPos: 0,
}))
}

func (bb *bytesBuffer) getBuffer() *buffer {
point := atomic.LoadPointer(&bb.bufferPointer)
return (*buffer)(point)
}

func (bb *bytesBuffer) read(dst []byte) (n int, err error) {
buff := bb.getBuffer()
readSize := (int64)(len(dst))
readEnd := atomic.AddInt64(&buff.readPos, readSize)
if readEnd > (int64)(3*len(buff.data)/4) {
go bb.readAhead()
if readEnd >= int64(len(buff.data)) {
return -1, io.EOF
}
}

return copy(dst, buff.data[readEnd-readSize:readEnd]), nil

}
func (bb *bytesBuffer) Read(dst []byte) (n int, err error) {
n, err = bb.read(dst)
if err != nil || n != len(dst) {
n, err = io.ReadFull(bb.src, dst)
}
return
}

func (bb *bytesBuffer) readAhead() (err error) {
if !atomic.CompareAndSwapUint32(&bb.status, 0, 1) {
return nil
}
defer atomic.StoreUint32(&bb.status, 0)

buf := make([]byte, bb.bufferSize)
readN, err := io.ReadFull(bb.src, buf[:])
if err != nil {
return err
}
if readN != bb.bufferSize {
return io.ErrUnexpectedEOF
}

bb.reset(buf)
return nil
}
2 changes: 1 addition & 1 deletion generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func newRFC4122Generator() Generator {
return &rfc4122Generator{
epochFunc: time.Now,
hwAddrFunc: defaultHWAddrFunc,
rand: rand.Reader,
rand: newBytesBuffer(4096, rand.Reader),
}
}

Expand Down