Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember 4.0 requires ember-auto-import >= 2 #152

Closed
sandydoo opened this issue Oct 11, 2021 · 1 comment
Closed

Ember 4.0 requires ember-auto-import >= 2 #152

sandydoo opened this issue Oct 11, 2021 · 1 comment
Labels
breaking :boom: Breaking changes

Comments

@sandydoo
Copy link
Owner

sandydoo commented Oct 11, 2021 •
edited
Loading

Looks like we’re being forced to do a major version bump. Investigate further.

Can I just drop the dependency? I don't import anything 🤣
@sandydoo sandydoo added the breaking :boom: Breaking changes label Oct 11, 2021
@sandydoo
Copy link
Owner Author

Fixed by #153.

We can just drop the dependency and avoid forcing downstream apps into adopting ember-auto-import >= 2. And for testing, we can use ember-try scenarios to add it as a dependency when testing against ember >= 4 or using embroider.
See 3c78cba.

sandydoo added a commit that referenced this issue Oct 13, 2021
@sandydoo
Implement simpler workaround for auto-import #152
9ddf504 
emberjs/ember.js#19761 (comment)

Apparently, we can add auto-import `>= 2` to our devDependencies
without *crosses fingers* any issue...as long as we don’t need it
in our addon code.

This is a partial revert for PR #153.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking :boom: Breaking changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sandydoo