Skip to content

Fix test_ast_expr for Python 3.13 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thunze
Copy link

@thunze thunze commented May 3, 2025

Python 3.13 introduced the show_empty keyword argument to ast.dump. If show_empty is False, ast.dump omits empty lists and fields that are None from its output.

Since show_empty=False is the default in Python 3.13 and ast.dump previously behaved like show_empty=True, the test_ast_expr test currently fails for Python ≥3.13.

Assuming devtools wants to keep the default behavior of ast.dump, I've split the test_ast_expr test into two parts, one testing for the default behavior under Python <3.13, one testing for the default behavior under Python ≥3.13.

See also: https://hydra.nixos.org/build/294880588/nixlog/2/tail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant