-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use ubuntu-22.04 to run tests #688
Conversation
There have been some changes in ubuntu24 that make it incompatible with nose. This will be eventually fixed but for now it will be good to have the test suite running.
@sahib would you mind disabling the "approval" requirement on MRs at least until we have sufficient activity and reviewers? I'll make sure to discuss non-trivial changes with other people but it will be nice to be able to have some changes pushed without that. (This change is needed as it's blocking a couple PRs). |
I think they will never get fixed upstream. |
@sahib You can revert that permission now. Thanks! |
I think he meant by rmlint, not by Ubuntu 😁 |
I think this one can be closed (not merged) as #687 should provide a more future proof solution. |
There have been some changes in ubuntu24 that make it incompatible with nose. This will be eventually fixed but for now it will be good to have the test suite running.