Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ubuntu-22.04 to run tests #688

Closed
wants to merge 1 commit into from
Closed

ci: use ubuntu-22.04 to run tests #688

wants to merge 1 commit into from

Conversation

fermino
Copy link
Collaborator

@fermino fermino commented Mar 1, 2025

There have been some changes in ubuntu24 that make it incompatible with nose. This will be eventually fixed but for now it will be good to have the test suite running.

There have been some changes in ubuntu24 that make it incompatible with
nose. This will be eventually fixed but for now it will be good to have
the test suite running.
@fermino
Copy link
Collaborator Author

fermino commented Mar 1, 2025

@sahib would you mind disabling the "approval" requirement on MRs at least until we have sufficient activity and reviewers? I'll make sure to discuss non-trivial changes with other people but it will be nice to be able to have some changes pushed without that. (This change is needed as it's blocking a couple PRs).
Thank you!

@vassilit
Copy link
Collaborator

vassilit commented Mar 2, 2025

I don't know what Ubuntu does, but both at least both Debian (although, not released) and Arch have working patched version of nose that works with Python 3.12+.

@sahib
Copy link
Owner

sahib commented Mar 2, 2025

@fermino Sure, I disabled it for now. Keep in mind that this lets people merge their own PRs though.

By the way: I get notifications when I get tagged explicitly. Best way to get me do any admin stuff would be to @sahib therefore.

@RayOei
Copy link
Collaborator

RayOei commented Mar 2, 2025

Keep in mind that this lets people merge their own PRs though.

@fermino @vassilit Ok with reinstating the PR review check?

@vassilit
Copy link
Collaborator

vassilit commented Mar 2, 2025

Keep in mind that this lets people merge their own PRs though.
@fermino @vassilit Ok with reinstating the PR review check?

Yes, certainly

@vassilit
Copy link
Collaborator

vassilit commented Mar 2, 2025

There have been some changes in ubuntu24 that make it incompatible with nose. This will be eventually fixed

I think they will never get fixed upstream.
Nose is unmaintained and use modules incompatibles with Python 3.12+. Debian used to have patch for that, but I see nose is not anymore in testing nor in sid. As Ubuntu is based on it, they won't restore nose-compatibility.
We are installing nose from pip rather than via packaging, so as a workaround what we could do for now if we want -latest is to patch it like as distributions do (#688 (comment)) and it should work.

@RayOei
Copy link
Collaborator

RayOei commented Mar 2, 2025

Keep in mind that this lets people merge their own PRs though.

@sahib You can revert that permission now. Thanks!

@RayOei
Copy link
Collaborator

RayOei commented Mar 2, 2025

This will be eventually fixed

I think he meant by rmlint, not by Ubuntu 😁
Issue #687 should resolve that as it will remove all dependencies. I am looking into that, based on the work done in #603. There are still a few nose references but by the looks of it, it should not be too hard to remove those as well.

@RayOei
Copy link
Collaborator

RayOei commented Mar 3, 2025

I think this one can be closed (not merged) as #687 should provide a more future proof solution.

@vassilit vassilit closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants