Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Synchronizing file from nextcloud does not set correct time stamp #1430

Merged
merged 4 commits into from
Feb 22, 2025

Conversation

QubaB
Copy link
Contributor

@QubaB QubaB commented Feb 19, 2025

When file is synchronized from remote (Nextcloud) to local, set file time stamp according to time stamp of remote file. This avoids problem than newly created note is immediately synchronized to nextcloud, because it has newer time stamp.

Another change:
In the file name are replaced \ to / before syncing to nextcloud. Windows use \ and such file is treated as different file than /. It caused problems with synchronization between windows and Android.

@adil192
Copy link
Member

adil192 commented Feb 22, 2025

Working for me! thank you so much

QubaB and others added 4 commits February 22, 2025 21:31
…file time stamp according to time stamp of remote file. This avoids problem than newly created note is immediately synchronized to nextcloud, because it has newer time stamp.

In the file name are replaced '\' to '/'  before syncing to nextcloud. Windows use '\' and such file is treated as different file than '/'.  It caused problems with synchronization between windows and Android.
@adil192 adil192 enabled auto-merge (rebase) February 22, 2025 21:33
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.22%. Comparing base (7eed1d3) to head (78f7483).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/data/file_manager/file_manager.dart 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
+ Coverage   47.20%   47.22%   +0.01%     
==========================================
  Files         114      114              
  Lines        8961     8966       +5     
==========================================
+ Hits         4230     4234       +4     
- Misses       4731     4732       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adil192 adil192 merged commit e81fab0 into saber-notes:main Feb 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants