Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop customer new v3.3 #392

Draft
wants to merge 7 commits into
base: develop_customer_new_base
Choose a base branch
from
Draft

Develop customer new v3.3 #392

wants to merge 7 commits into from

Conversation

charlie-ai
Copy link
Collaborator

@charlie-ai charlie-ai commented Mar 13, 2025 •
edited by fengtai-telink
Loading

!!!!!!!!!! Please delete the instructions below and replace with PR description

If you have an issue number, please use a syntax of
Fixes #12345 and a brief change description

If you do not have an issue number, please have a good description of
the problem and the fix. Help the reviewer understand what to expect.

Make sure you delete these instructions (to prove you have read them).

!!!!!!!!!! Instructions end

Testing

Verified by CI

haiwentelink and others added 5 commits March 11, 2025 20:05
@haiwentelink @charlie-ai
riscv:telink: update commit id and nvs config.
a9bb438 
- update commit id for zephyr.
- add NVS_RAM_OPTIMIZATION option.

Signed-off-by: Haiwen Xia <[email protected]>
@haiwentelink @charlie-ai
riscv:telink: add config for csma backoff.
5081ec8 
- set csma backoff in retention mode .

Signed-off-by: Haiwen Xia <[email protected]>
@damien0x0023 @charlie-ai
[Telink] ieee802154 optimization for power consumption (#360)
42196d5 
* [Telink] ieee802154 optimization for power consumption

- reduce COMMON_LIBC_MALLOC_ARENA_SIZE to 13.5KB.
- add configs
  - OPENTHREAD_CSMABACKOFF_OPTIMIZATION,
  - ZEPHYR_NETBUFFER_OPTIMIZATION,
  - IEEE802154_TLX_OPTIMIZATION.
- reduce PACKETBUFFER_CAPACITY_MAX to 1024.
- remove shell in tl321x light switch app CI.
- update zephyr revision.

Signed-off-by: Damien Ji <[email protected]>

---------

Signed-off-by: Damien Ji <[email protected]>
@haiwentelink @charlie-ai
riscv: telink: add compile support for tl3218x .
eeb54c2 
- fix retention ram.

Signed-off-by: Haiwen Xia <[email protected]>
@haiwentelink @charlie-ai
riscv: telink: add one macro for tlsr9528a retention .
5fcd406 
- optimize the power.

Signed-off-by: Haiwen Xia <[email protected]>
@charlie-ai charlie-ai requested a review from s07641069 as a code owner March 13, 2025 08:43
@charlie-ai charlie-ai marked this pull request as draft March 13, 2025 08:44
@charlie-ai charlie-ai added the DNM label Mar 13, 2025
s07641069
s07641069 requested changes Mar 13, 2025
View reviewed changes
config/telink/chip-module/Kconfig.defaults
Comment on lines +268 to +270
default 2048 if SOC_RISCV_TELINK_TL321X
default 2048 if !PM
default 2048
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case if all values are same we can use only one default value instead of three:
default 2048

src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp Outdated
@@ -66,6 +66,10 @@ extern "C" void otSysProcessDrivers(otInstance * aInstance);
extern "C" void otAppCliInit(otInstance * aInstance);
#endif

#if defined CONFIG_IEEE802154_TLX_OPTIMIZATION && CONFIG_IEEE802154_TLX_OPTIMIZATION
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better to use #if defined for both configs like:
#if defined CONFIG_IEEE802154_TLX_OPTIMIZATION && defined CONFIG_IEEE802154_TLX_OPTIMIZATION
because in case if CONFIG_IEEE802154_TLX_OPTIMIZATION=n it will be undefined

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree

src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp Outdated
@@ -379,6 +383,14 @@ bool GenericThreadStackManagerImpl_OpenThread<ImplClass>::_IsThreadAttached()
curRole = otThreadGetDeviceRole(mOTInst);
Impl()->UnlockThreadStack();

#if defined CONFIG_IEEE802154_TLX_OPTIMIZATION && CONFIG_IEEE802154_TLX_OPTIMIZATION
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here
#if defined CONFIG_IEEE802154_TLX_OPTIMIZATION && defined CONFIG_IEEE802154_TLX_OPTIMIZATION

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree

@charlie-ai
telink: test CI
715d9cc 
     - test CI

Signed-off-by: Lingzhi Chen <[email protected]>
@s07641069
Copy link
Owner

Also I suggest you to include changes from project-chip#36691 which add Matter GitHub CI builds for both Zephyr versions or wait till this PR will be merged into master and after you can rebase your branch.
It will help you to check that all targets builds fine for both Zephyr versions.

@charlie-ai
telink: Optimizing the code
9b0a5e7 
     - Optimizing the code

Signed-off-by: Lingzhi Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s07641069 s07641069 s07641069 requested changes

Assignees
No one assigned
Labels
config DNM github platform telink workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charlie-ai @s07641069 @haiwentelink @damien0x0023