Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose once_cell publically #13

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Don't expose once_cell publically #13

merged 1 commit into from
Jun 17, 2023

Conversation

kchibisov
Copy link
Member

Fixes #12.

r @notgull

--

I wasn't sure why I needed a dlib update in the first place though.

notgull
notgull requested changes Jun 17, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the error message was somehow propagated, since it may be useful in determining how loading this library failed.

@kchibisov
Copy link
Member Author

Hm, it's propagated via the log, but I don't think we should use log in the first place?

notgull
notgull approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's logged, then I have no complaints. Looks good to me!

@kchibisov kchibisov merged commit 0e6224f into master Jun 17, 2023
@kchibisov kchibisov deleted the dlib branch June 17, 2023 13:44
@notgull
Copy link
Member

notgull commented Jun 17, 2023

I wasn't sure why I needed a dlib update in the first place though.

The update was so that expressions could be used in the place of the library handle, see elinorbgr/dlib#21

@kchibisov
Copy link
Member Author

I think you could use it in the ffi_dispatch!, but we don't use ffi_dispatch downstream...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't expose once_cell in the public API
2 participants
@kchibisov @notgull