Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GH Actions #1538

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Adjust GH Actions #1538

merged 6 commits into from
Nov 27, 2024

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Nov 27, 2024

Tweak the GH Actions:

  • Clippy and rustfmt both now run on rustc stable. (We did pin Clippy to 1.78, but no one remembered to update this. Avoiding usage of Clippy on nightly does avoid many of its update problems in my experience.)
  • Run Clippy and rustfmt from the main test job, not a dedicated job. This is easier to read on the Actions page in my opinion.
  • Run benchmark tests from the benches job. This is more logical. It does mean we need to run that job on changes to the main source tree, but that's not a big deal IMO since the Clippy/rustfmt jobs are very fast.
  • Likewise for distr_test
  • Tweak rules on when jobs run

@dhardy dhardy requested a review from newpavlov November 27, 2024 08:14
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy and rustfmt both now run on rustc stable.

Clippy routinely gets new lints. So using the stable toolchain can result in unrelated CI failures on new stable releases. This is why I think it's worth to keep a fixed version and bump it manually from time to time.

@dhardy
Copy link
Member Author

dhardy commented Nov 27, 2024

I know; I've been hit by a few that appeared on nightly (often being adjusted before hitting stable). But I suspect we will forget to update this otherwise, and we would need to specify in three places.

@dhardy dhardy merged commit b879689 into rust-random:master Nov 27, 2024
17 checks passed
benjamin-lieser pushed a commit to benjamin-lieser/rand that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants