config: Stabilize binop_separator again. #5549
Conversation
|
@ytmimi review ping? |
emilio
force-pushed
the
binop-separator-again
branch
from
876e29e to
c2dcf8b
Compare
|
@calebcartwright do you think we're ready to stabilize this option again? |
Yes I believe so. Would you mind doing a quick scan through the issue tracker to make sure there aren't any 1.x bugs that would be relevant here that weren't relevant for the 2.x stabilization? |
|
Ping here? |
|
@emilio thanks for reaching out to put this back on the team's radar. We're currently focused on some higher priority items like |
|
Thanks for the update! |
|
Gentle ping? @ytmimi |
See reasoning in rust-lang#4144, which still applies. Other projects like bindgen etc also use it by default, and this would allow them to move to stable rust. Fixes rust-lang#3368 again.
emilio
force-pushed
the
binop-separator-again
branch
from
c2dcf8b to
032421a
Compare
|
Rebased |
|
@calebcartwright / @ytmimi, any chance of getting this merged? I don't see any relevant issue in the tracker about this option after a quick scan, and this makes Servo and Firefox need nightly rustfmt but stable rust, which is kind of annoying... :) |
|
(Plus we've been using this option for ~ever, without any issue) |
|
Hey @emilio thanks for reaching out again and sorry that this one still hasn't gotten much attention from the team. I'm going to bring this up for discussion in our next team meeting. |
|
@ytmimi any update? Happy to rebase if needed. |
See reasoning in #4144, which still applies. Other projects like bindgen etc also use it by default, and this would allow them to move to stable rust.
Fixes #3368 again.