Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar mistake in monomorph.md? #1584

Closed
Ciel-MC opened this issue Feb 5, 2023 · 1 comment · Fixed by #1585
Closed

Grammar mistake in monomorph.md? #1584

Ciel-MC opened this issue Feb 5, 2023 · 1 comment · Fixed by #1585
Labels
E-easy Difficulty: might be a good place for a beginner

Comments

@Ciel-MC
Copy link
Contributor

Ciel-MC commented Feb 5, 2023

At the bottom of the page, there's a paragraph that starts with: "unused_generic_params will also invoked during code generation [...]", which to me, doesn't make much sense, was it perhaps intended to be "will also be invoked"?
@JohnTitor
Copy link
Member

Seems so, could you open a PR to fix it?

@JohnTitor JohnTitor added E-help-wanted Call for participation: extra help is wanted E-easy Difficulty: might be a good place for a beginner and removed E-help-wanted Call for participation: extra help is wanted labels Feb 5, 2023
@JohnTitor JohnTitor mentioned this issue Feb 5, 2023
Merged
JohnTitor pushed a commit that referenced this issue Feb 5, 2023
@Ciel-MC
Fixed small grammar mistake in monomorph.md (#1585)
0591410 
Fixes #1584
Kobzol pushed a commit to Kobzol/rust that referenced this issue Dec 30, 2024
@Ciel-MC
Fixed small grammar mistake in monomorph.md (rust-lang#1585)
154dbac 
Fixes rust-lang/rustc-dev-guide#1584
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
@Ciel-MC
Fixed small grammar mistake in monomorph.md (rust-lang#1585)
b5eae12 
Fixes rust-lang/rustc-dev-guide#1584
Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this issue Jan 3, 2025
@Ciel-MC
Fixed small grammar mistake in monomorph.md (rust-lang#1585)
5471f42 
Fixes rust-lang#1584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Difficulty: might be a good place for a beginner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed small grammar mistake in monomorph.md Ciel-MC/rustc-dev-guide
2 participants
@JohnTitor @Ciel-MC