Skip to content

Commit ad8ebf2

Browse files
committedNov 19, 2018
finish walkthrough
1 parent 0f3cb5e commit ad8ebf2

File tree

1 file changed

+28
-3
lines changed

1 file changed

+28
-3
lines changed
 

‎src/walkthrough.md

+28-3
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,34 @@ members.
228228
For the `?` macro feature, we went through a few different iterations after the
229229
original implementation: [1][impl2], [2][impl3], [3][impl4].
230230

231-
TODO
232-
231+
Along the way, we decided that `?` should not take a separator, which was
232+
previously an unresolved question listed in the RFC. We also changed the
233+
disambiguation strategy: we decided to remove the ability to use `?` as a
234+
separator token for other repetition operators (e.g. `+` or `*`). However,
235+
since this was a breaking change, we decided to do it over an edition boundary.
236+
Thus, the new feature can be enabled only in edition 2018. These deviations
237+
from the original RFC required [another
238+
FCP](https://github.com/rust-lang/rust/issues/51934).
233239

234240
## Stabilization
235241

236-
TODO
242+
Finally, after the feature had baked for a while on nightly, a language team member
243+
[moved to stabilize it][stabilizefcp].
244+
245+
[stabilizefcp]: https://github.com/rust-lang/rust/issues/48075#issuecomment-433177613
246+
247+
A _stabilization report_ needs to be written that includes
248+
249+
- brief description of the behavior and any deviations from the RFC
250+
- which edition(s) are affected and how
251+
- links to a few tests to show the interesting aspects
252+
253+
The stabilization report for our feature is [here][stabrep].
254+
255+
[stabrep]: https://github.com/rust-lang/rust/issues/48075#issuecomment-433243048
256+
257+
After this, a PR is made to remove the feature gate, enabling the feature by
258+
default (on the 2018 edition). A note is added to the [Release notes][relnotes]
259+
about the feature.
260+
261+
[relnotes]: https://github.com/rust-lang/rust/blob/master/RELEASES.md

0 commit comments

Comments
 (0)
Please sign in to comment.