@@ -120,17 +120,16 @@ itself to reflect the course of the discussion (e.g. new alternatives or prior
120
120
work may be added or you may decide to change parts of the proposal itself).
121
121
122
122
In the end, when the discussion seems to reach a consensus and die down a bit,
123
- a rust team member may propose [ to merge the RFC] [ rfcmerge ] . This means that
124
- they want the other members of the appropriate teams to review and comment on
125
- the RFC. More changes may be proposed. At some point, when everyone is
123
+ a rust team member may propose to move to FCP with one of three possible dispositions.
124
+ This means that they want the other members of the appropriate teams to review
125
+ and comment on the RFC. More discussion may ensue, which may result in more changes
126
+ or unresolved questions being added. At some point, when everyone is
126
127
satisfied, the RFC enters the "final comment period" (FCP), which is the last
127
- chance for people to bring up objections. When the FCP is over, the RFC is
128
- "merged" (or accepted).
129
-
130
- [ rfcmerge ] : https://github.com/rust-lang/rfcs/pull/2298#issuecomment-360582667
131
-
132
- Some other possible outcomes might be for a team member to propose to
128
+ chance for people to bring up objections. When the FCP is over, the disposition is
129
+ adopted. Here are the three possible dispositions:
133
130
131
+ - _ Merge_ : accept the feature. Here is the proposal to merge for our [ ` ? ` macro
132
+ feature] [ rfcmerge ] .
134
133
- _ Close_ : this feature in its current form is not a good fit for rust. Don't
135
134
be discouraged if this happens to your RFC, and don't take it personally.
136
135
This is not a reflection on you, but rather a community decision that rust
@@ -141,6 +140,15 @@ Some other possible outcomes might be for a team member to propose to
141
140
this is the case when the feature doesn't fit into the team's roadmap.
142
141
Postponed ideas may be revisited later.
143
142
143
+ [ rfcmerge ] : https://github.com/rust-lang/rfcs/pull/2298#issuecomment-360582667
144
+
145
+ When an RFC is merged, the PR is merged into the RFCs repo. A new _ tracking
146
+ issue_ is created in the [ rust-lang/rust] repo to track progress on the feature
147
+ and discuss unresolved questions, implementation progress and blockers, etc.
148
+ Here is the tracking issue on for our [ ` ? ` macro feature] [ tracking ] .
149
+
150
+ [ tracking ] : https://github.com/rust-lang/rust/issues/48075
151
+
144
152
<a name =" impl " ></a >
145
153
146
154
## Implementation
@@ -199,15 +207,30 @@ There are a couple of things that may happen for some PRs during the review proc
199
207
to check if you introduced a change to compiler behavior that affects a large
200
208
portion of the ecosystem.
201
209
- If the diff of your PR is large or the reviewer is busy, your PR may have
202
- some merge conflicts with other PRs. You should fix these merge conflicts
203
- using the normal git procedures.
210
+ some merge conflicts with other PRs that happen to get merged first. You
211
+ should fix these merge conflicts using the normal git procedures.
204
212
205
213
[ crater ] : ./tests/intro.html#crater
206
214
215
+ If you are not doing a new feature or something like that (e.g. if you are
216
+ fixing a bug), then that's it! Thanks for your contribution :)
217
+
207
218
## Refining your implementation
208
219
220
+ As people get experience with your new feature on nightly, slight changes may
221
+ be proposed and unresolved questions may become resolved. Updates/changes go
222
+ through the same process for implementing any other changes, as described
223
+ above (i.e. submit a PR, go through review, wait for ` @bors ` , etc).
224
+
225
+ Some changes may be major enough to require an FCP and some review by rust team
226
+ members.
227
+
228
+ For the ` ? ` macro feature, we went through a few different iterations after the
229
+ original implementation: [ 1] [ impl2 ] , [ 2] [ impl3 ] , [ 3] [ impl4 ] .
230
+
209
231
TODO
210
232
233
+
211
234
## Stabilization
212
235
213
236
TODO
0 commit comments