Skip to content

Commit 0f3cb5e

Browse files
committedNov 11, 2018
add a bit more
1 parent a5b158f commit 0f3cb5e

File tree

1 file changed

+34
-11
lines changed

1 file changed

+34
-11
lines changed
 

‎src/walkthrough.md

+34-11
Original file line numberDiff line numberDiff line change
@@ -120,17 +120,16 @@ itself to reflect the course of the discussion (e.g. new alternatives or prior
120120
work may be added or you may decide to change parts of the proposal itself).
121121

122122
In the end, when the discussion seems to reach a consensus and die down a bit,
123-
a rust team member may propose [to merge the RFC][rfcmerge]. This means that
124-
they want the other members of the appropriate teams to review and comment on
125-
the RFC. More changes may be proposed. At some point, when everyone is
123+
a rust team member may propose to move to FCP with one of three possible dispositions.
124+
This means that they want the other members of the appropriate teams to review
125+
and comment on the RFC. More discussion may ensue, which may result in more changes
126+
or unresolved questions being added. At some point, when everyone is
126127
satisfied, the RFC enters the "final comment period" (FCP), which is the last
127-
chance for people to bring up objections. When the FCP is over, the RFC is
128-
"merged" (or accepted).
129-
130-
[rfcmerge]: https://github.com/rust-lang/rfcs/pull/2298#issuecomment-360582667
131-
132-
Some other possible outcomes might be for a team member to propose to
128+
chance for people to bring up objections. When the FCP is over, the disposition is
129+
adopted. Here are the three possible dispositions:
133130

131+
- _Merge_: accept the feature. Here is the proposal to merge for our [`?` macro
132+
feature][rfcmerge].
134133
- _Close_: this feature in its current form is not a good fit for rust. Don't
135134
be discouraged if this happens to your RFC, and don't take it personally.
136135
This is not a reflection on you, but rather a community decision that rust
@@ -141,6 +140,15 @@ Some other possible outcomes might be for a team member to propose to
141140
this is the case when the feature doesn't fit into the team's roadmap.
142141
Postponed ideas may be revisited later.
143142

143+
[rfcmerge]: https://github.com/rust-lang/rfcs/pull/2298#issuecomment-360582667
144+
145+
When an RFC is merged, the PR is merged into the RFCs repo. A new _tracking
146+
issue_ is created in the [rust-lang/rust] repo to track progress on the feature
147+
and discuss unresolved questions, implementation progress and blockers, etc.
148+
Here is the tracking issue on for our [`?` macro feature][tracking].
149+
150+
[tracking]: https://github.com/rust-lang/rust/issues/48075
151+
144152
<a name="impl"></a>
145153

146154
## Implementation
@@ -199,15 +207,30 @@ There are a couple of things that may happen for some PRs during the review proc
199207
to check if you introduced a change to compiler behavior that affects a large
200208
portion of the ecosystem.
201209
- If the diff of your PR is large or the reviewer is busy, your PR may have
202-
some merge conflicts with other PRs. You should fix these merge conflicts
203-
using the normal git procedures.
210+
some merge conflicts with other PRs that happen to get merged first. You
211+
should fix these merge conflicts using the normal git procedures.
204212

205213
[crater]: ./tests/intro.html#crater
206214

215+
If you are not doing a new feature or something like that (e.g. if you are
216+
fixing a bug), then that's it! Thanks for your contribution :)
217+
207218
## Refining your implementation
208219

220+
As people get experience with your new feature on nightly, slight changes may
221+
be proposed and unresolved questions may become resolved. Updates/changes go
222+
through the same process for implementing any other changes, as described
223+
above (i.e. submit a PR, go through review, wait for `@bors`, etc).
224+
225+
Some changes may be major enough to require an FCP and some review by rust team
226+
members.
227+
228+
For the `?` macro feature, we went through a few different iterations after the
229+
original implementation: [1][impl2], [2][impl3], [3][impl4].
230+
209231
TODO
210232

233+
211234
## Stabilization
212235

213236
TODO

0 commit comments

Comments
 (0)
Please sign in to comment.