Better error on attempt to rebind identifier for static constant. #9683
Conversation
| } | ||
|
|
||
| fn main() { | ||
| let b = 4; //~ERROR only irrefutable patterns allowed here |
There was a problem hiding this comment.
Isn't this basically testing what the behavior already was? It'd be nice to have the 'static constant' message also asserted here.
There was a problem hiding this comment.
Well, I did fix the message to say "irrefutable" instead of "refutable", so technically, this test would flag the previous behavior as wrong. :)
I can throw in the static constant bit, I guess. I don't know what rhyme or reason is typically followed when deciding how much of the error message to include. (I've been idly trying to figure out if I could actually point the user at the span of the relevant import or definition of the static constant, to make things crystal clear...)
There was a problem hiding this comment.
Oh good point, sorry I missed that! I think that the ability is being added soon as well to have //~ ERROR long message [...] other contents with the discriminant pull request, so you'd be able to omit the middle stuff.
A NOTE would be nice, but probably not necessary, especially if you mention that it's already a static constant.
|
needs a rebase :( |
r? anyone.
Fix #7526.