Skip to content

Fix documentation error #75499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix documentation error #75499

merged 1 commit into from
Aug 19, 2020
+1 −1

Conversation

jack-champagne
Copy link
Contributor

@jack-champagne jack-champagne commented Aug 13, 2020 •
edited by JohnTitor
Loading

This should fix #75412. Just a quick >= to > sign replacement.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2020
JohnTitor
JohnTitor approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good :)

@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

📌 Commit 9b0f3d1 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2020
@bors
Copy link
Collaborator

bors commented Aug 16, 2020

⌛ Testing commit 9b0f3d1 with merge 7e914647c8eb4821f964f01b80754279c1487ea8...

@bors
Copy link
Collaborator

bors commented Aug 16, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2020
@Dylan-DPC-zz
Copy link

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2020
@jack-champagne
Copy link
Contributor Author

Might I ask why homu has a job named "mark job as failure" with the command exit 1 to always throw a failed signal? I know this is not on-topic for completing this PR, I can move this to discord to discuss with someone who has the answer to this.

@JohnTitor
Copy link
Member

Might I ask why homu has a job named "mark job as failure" with the command exit 1 to always throw a failed signal? I know this is not on-topic for completing this PR, I can move this to discord to discuss with someone who has the answer to this.

Because we cannot tell homu that the build failed without it in GHA. If you have further questions, feel free to ask on the Zulip stream: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra

@jack-champagne
Copy link
Contributor Author

Might I ask why homu has a job named "mark job as failure" with the command exit 1 to always throw a failed signal? I know this is not on-topic for completing this PR, I can move this to discord to discuss with someone who has the answer to this.

Because we cannot tell homu that the build failed without it in GHA. If you have further questions, feel free to ask on the Zulip stream: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra

Thanks, understood

tmandry added a commit to tmandry/rust that referenced this pull request Aug 18, 2020
@tmandry
Rollup merge of rust-lang#75499 - jack-champagne:jack-champagne/issue…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bc4b517 
…-75412, r=Dylan-DPC

Fix documentation error

This should fix rust-lang#75412. Just a quick >= to > sign replacement.
@tmandry tmandry mentioned this pull request Aug 18, 2020
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Aug 18, 2020
@tmandry
Rollup merge of rust-lang#75499 - jack-champagne:jack-champagne/issue…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
61e2369 
…-75412, r=Dylan-DPC

Fix documentation error

This should fix rust-lang#75412. Just a quick >= to > sign replacement.
@tmandry tmandry mentioned this pull request Aug 18, 2020
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandry
Rollup merge of rust-lang#75499 - jack-champagne:jack-champagne/issue…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5fe695b 
…-75412, r=Dylan-DPC

Fix documentation error

This should fix rust-lang#75412. Just a quick >= to > sign replacement.
@tmandry tmandry mentioned this pull request Aug 19, 2020
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandry
Rollup merge of rust-lang#75499 - jack-champagne:jack-champagne/issue…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9112168 
…-75412, r=Dylan-DPC

Fix documentation error

This should fix rust-lang#75412. Just a quick >= to > sign replacement.
@tmandry tmandry mentioned this pull request Aug 19, 2020
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandry
Rollup merge of rust-lang#75499 - jack-champagne:jack-champagne/issue…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9b5522a 
…-75412, r=Dylan-DPC

Fix documentation error

This should fix rust-lang#75412. Just a quick >= to > sign replacement.
@tmandry tmandry mentioned this pull request Aug 19, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Aug 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 19, 2020
@bors
Auto merge of rust-lang#75692 - JohnTitor:rollup-8gr04ah, r=JohnTitor
5b04bbf 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#75038 (See also X-Link mem::{swap, take, replace})
 - rust-lang#75049 (docs(marker/copy): provide example for `&T` being `Copy`)
 - rust-lang#75499 (Fix documentation error)
 - rust-lang#75554 (Fix clashing_extern_declarations stack overflow for recursive types.)
 - rust-lang#75646 (Move to intra doc links for keyword documentation)
 - rust-lang#75652 (Resolve true and false as booleans)
 - rust-lang#75658 (Don't emit "is not a logical operator" error outside of associative expressions)
 - rust-lang#75665 (Add doc examples coverage)
 - rust-lang#75685 (Switch to intra-doc links in /src/sys/unix/ext/*.rs)

Failed merges:

r? @ghost
@bors bors merged commit ac264b5 into rust-lang:master Aug 19, 2020
@jack-champagne jack-champagne deleted the jack-champagne/issue-75412 branch August 19, 2020 18:49
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

DOC: slicing with begin = end?
7 participants
@jack-champagne @rust-highfive @Dylan-DPC-zz @bors @JohnTitor @cuviper @shepmaster