Skip to content

Remove the --no-threads workaround for wasm targets. #75161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

sunfishcode
Copy link
Member

Remove --no-threads from the wasm-ld command-line, which was a
workaround for an old bug which was fixed in LLVM 9.0, and is
no longer needed.

Also, the --no-threads option has been removed upstream.

r? @alexcrichton

Remove `--no-threads` from the wasm-ld command-line, which was a
workaround for [an old bug] which was fixed in LLVM 9.0, and is
no longer needed.

Also, the `--no-threads` option has been [removed upstream].

[an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508
[removed upstream]: https://reviews.llvm.org/D76885
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 4, 2020

📌 Commit 1a3e4d8 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@bors
Copy link
Collaborator

bors commented Aug 4, 2020

⌛ Testing commit 1a3e4d8 with merge 07f1fde...

@bors
Copy link
Collaborator

bors commented Aug 5, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: alexcrichton
Pushing 07f1fde to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2020
@bors bors merged commit 07f1fde into rust-lang:master Aug 5, 2020
@sunfishcode sunfishcode deleted the wasm-no-threads branch August 5, 2020 00:15
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants