Skip to content

Detect turbofish missing surrounding angle brackets #74687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2020
Merged

Detect turbofish missing surrounding angle brackets #74687

merged 2 commits into from
Jul 25, 2020
+114 −4

Conversation

estebank
Copy link
Contributor

Fix #74065.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2020
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 25, 2020

📌 Commit d090e5e has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 25, 2020
@Manishearth
Rollup merge of rust-lang#74687 - estebank:bracketless-turbofish, r=m…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8afc46d 
…atthewjasper

Detect turbofish missing surrounding angle brackets

Fix rust-lang#74065.
@Manishearth Manishearth mentioned this pull request Jul 25, 2020
Closed
@bors
Copy link
Collaborator

bors commented Jul 25, 2020

⌛ Testing commit d090e5e with merge f06e8e1...

@bors
Copy link
Collaborator

bors commented Jul 25, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: matthewjasper
Pushing f06e8e1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2020
@bors bors merged commit f06e8e1 into rust-lang:master Jul 25, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

Detect invalid turbofish foo.bar::Type<T>()in the parser
5 participants
@estebank @rust-highfive @matthewjasper @bors @cuviper