Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -Zborrowck=mir for NLL compare mode #60171

Merged
merged 2 commits into from
May 17, 2019
Merged

Use -Zborrowck=mir for NLL compare mode #60171

merged 2 commits into from
May 17, 2019

Conversation

matthewjasper
Copy link
Contributor

closes #56993

r? @pnkfelix

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2019
@matthewjasper matthewjasper force-pushed the full-nll-compare-mode branch from 14ab5e8 to 1444c05 Compare April 22, 2019 15:57
@matthewjasper matthewjasper mentioned this pull request Apr 28, 2019
Closed
@matthewjasper matthewjasper force-pushed the full-nll-compare-mode branch 2 times, most recently from 049c4c9 to 8fa44c0 Compare May 4, 2019 11:35
@matthewjasper matthewjasper force-pushed the full-nll-compare-mode branch from 8fa44c0 to be5fe05 Compare May 12, 2019 18:51
@pnkfelix pnkfelix mentioned this pull request May 12, 2019
Closed
@pnkfelix
Copy link
Member

pnkfelix commented May 13, 2019 •
edited
Loading

Sorry its taken me so long to take a look at this.

@matthewjasper , did you already manually review those new .nll.stderr's? I started looking through them, but its too many to do via Github interface in a single review. And I'm basically wondering whether we need to plan for a new round of going over all of the diffs between the .stderr and .nll.stderr files.

@matthewjasper
Copy link
Contributor Author

I checked that there was nothing completely unexpected, but an actual review is needed.

@pnkfelix
Copy link
Member

Okay.

I think our best bet is to land this, and then do a review in an incremental fashion as a follow-up task.

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit be5fe05 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2019
@pnkfelix
Copy link
Member

(the PR is probably out of date, but I'll just let bors tell us if that's true.)

@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Testing commit be5fe05 with merge b982867...

bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of #60171 - matthewjasper:full-nll-compare-mode, r=pnkfelix
b982867 
Use -Zborrowck=mir for NLL compare mode

closes #56993

r? @pnkfelix
@bors
Copy link
Contributor

bors commented May 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pnkfelix
Pushing b982867 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2019
@bors bors merged commit be5fe05 into rust-lang:master May 17, 2019
This was referenced May 17, 2019
Merged
Merged
@matthewjasper matthewjasper deleted the full-nll-compare-mode branch July 29, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

region tests incorrectly passing with NLL enabled
4 participants
@matthewjasper @pnkfelix @bors @rust-highfive