Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const #58750

TimDiekmann · 2019-02-26T09:15:21Z

No description provided.

rust-highfive · 2019-02-26T09:15:24Z

(rust_highfive has picked a reviewer for you, use r? to override)

oli-obk · 2019-02-26T09:43:52Z

Please add some tests using these in a const context. Also consider making them rustc_const_unstable so the constness isn't insta-stable

TimDiekmann · 2019-02-26T09:51:35Z

Should rustc_const_unstable also apply on Unique as it's ~~not pub~~ unstable?

r? @oli-obk

oli-obk · 2019-02-26T10:23:07Z

Since it's unstable, there's no need

rust-highfive · 2019-02-26T11:26:44Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:01f4ae1b:start=1551179575121358287,finish=1551179578001919871,duration=2880561584
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:37] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:37] tidy error: /checkout/src/libcore/ptr.rs:2905: trailing whitespace
[00:03:37] tidy error: /checkout/src/test/ui/consts/const-ptr-nonnull.rs:4: line longer than 100 chars
[00:03:37] tidy error: /checkout/src/test/ui/consts/const-ptr-nonnull.rs:5: trailing whitespace
[00:03:37] tidy error: /checkout/src/test/ui/consts/const-ptr-nonnull.rs:8: line longer than 100 chars
[00:03:37] tidy error: /checkout/src/test/ui/consts/const-ptr-unique.rs:8: line longer than 100 chars
[00:03:37] tidy error: /checkout/src/test/run-pass/consts/const-ptr-nonnull.rs:17: trailing whitespace
[00:03:38] some tidy checks failed
[00:03:38] 
[00:03:38] 
[00:03:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:38] 
[00:03:38] 
[00:03:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:38] Build completed unsuccessfully in 0:00:44
[00:03:38] Build completed unsuccessfully in 0:00:44
[00:03:38] make: *** [tidy] Error 1
[00:03:38] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:015d7ce3
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Feb 26 11:16:47 UTC 2019
---
travis_time:end:1af693c0:start=1551179807939747195,finish=1551179807944240954,duration=4493759
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:025d155c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:013a19e7
travis_time:start:013a19e7
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0672f22e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libcore/ptr.rs

src/test/run-pass/consts/const-ptr-nonnull.rs

oli-obk · 2019-02-26T13:26:06Z

src/libcore/ptr.rs

@@ -2790,7 +2790,7 @@ impl<T: ?Sized> Unique<T> {
    }

    /// Acquires the underlying `*mut` pointer.
-    pub fn as_ptr(self) -> *mut T {
+    pub const fn as_ptr(self) -> *mut T {


cc @Centril is it too dangerous that just adding a const doesn't require anything like a #[const_stable(since = "1.2.3")] attribute?

Dangerous from what perspective? If it's used in a min-const-fn it will also need to be min-const-fn... or do you mean from the POV of accidental stabilization?

yes, accidental stabilization. Like making something stable that is already const fn stabilizes the constness along with it.

Do you mean any stabilized const fn should have something like a #[const_stable] attribute?

Ah... idk if I find it risky rising to the level of dangerous but there's some risk, no doubt. @varkor wanted it from a different perspective (#57562 (comment)) but I thought it too much of an annotation burden. However, from the POV of accidental stabilization, #[const_stable(...)] makes sense to me.

Can you open up an issue and cc me and varkor?

@TimDiekmann Yeah, that's the idea.

oli-obk · 2019-02-26T13:27:58Z

@bors r+

bors · 2019-02-26T13:27:59Z

📌 Commit c5f3830 has been approved by oli-obk

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

Centril · 2019-02-27T07:59:10Z

Failed in #58766 (comment), @bors r-

Make `Unique::as_ptr` const without feature attribute as it's unstable Make `NonNull::dangling` and `NonNull::cast` const with `feature = "const_ptr_nonnull"`

TimDiekmann · 2019-03-04T08:58:39Z

Yes, indeed, very helpful!

bors · 2019-03-04T10:48:57Z

⌛ Testing commit 60a649e with merge 28660c5782de2bb06e1571d5eb9491a7316c4647...

bors · 2019-03-04T14:05:00Z

💔 Test failed - status-appveyor

TimDiekmann · 2019-03-04T14:11:04Z

Command exited with code 259

Seems like a spurious failure as mentioned in #58160.

ljedrz · 2019-03-04T14:26:22Z

@bors retry

bors · 2019-03-04T20:20:19Z

⌛ Testing commit 60a649e with merge 053b2117f7e4b3bbbf1130289882f6772813bea4...

bors · 2019-03-04T23:25:16Z

💔 Test failed - status-appveyor

Centril · 2019-03-05T07:01:53Z

@bors retry

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

@ghost

Rollup of 13 pull requests Successful merges: - #58518 (Use early unwraps instead of bubbling up errors just to unwrap in the end) - #58626 (rustdoc: add option to calculate "documentation coverage") - #58629 (rust-lldb: fix crash when printing empty string) - #58660 (MaybeUninit: add read_initialized, add examples) - #58670 (fixes #52482) - #58676 (look for python2 symlinks before bootstrap python) - #58679 (Refactor passes and pass execution to be more parallel) - #58750 (Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const) - #58762 (Mention `unwind(aborts)` in diagnostics for `#[unwind]`) - #58924 (Add as_slice() to slice::IterMut and vec::Drain) - #58990 (Actually publish miri in the manifest) - #59018 (std: Delete a by-definition spuriously failing test) - #59045 (Expose new_sub_parser_from_file) Failed merges: r? @ghost

rust-highfive assigned Kimundi Feb 26, 2019

rust-highfive added the S-waiting-on-review label Feb 26, 2019

rust-highfive assigned oli-obk and unassigned Kimundi Feb 26, 2019

oli-obk reviewed Feb 26, 2019

View reviewed changes

src/libcore/ptr.rs Outdated Show resolved Hide resolved

oli-obk reviewed Feb 26, 2019

View reviewed changes

src/test/run-pass/consts/const-ptr-nonnull.rs Outdated Show resolved Hide resolved

oli-obk reviewed Feb 26, 2019

View reviewed changes

bors added S-waiting-on-bors and removed S-waiting-on-review labels Feb 26, 2019

Centril added a commit to Centril/rust that referenced this pull request Feb 27, 2019

Rollup merge of rust-lang#58750 - TimDiekmann:master, r=oli-obk

4253413

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

Centril mentioned this pull request Feb 27, 2019

Rollup of 18 pull requests #58763

Closed

Centril added a commit to Centril/rust that referenced this pull request Feb 27, 2019

Rollup merge of rust-lang#58750 - TimDiekmann:master, r=oli-obk

af6b494

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

Centril mentioned this pull request Feb 27, 2019

Rollup of 17 pull requests #58764

Closed

Centril added a commit to Centril/rust that referenced this pull request Feb 27, 2019

Rollup merge of rust-lang#58750 - TimDiekmann:master, r=oli-obk

0dbd5e5

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

Centril mentioned this pull request Feb 27, 2019

Rollup of 16 pull requests #58766

Closed

bors added S-waiting-on-author and removed S-waiting-on-bors labels Feb 27, 2019

oli-obk mentioned this pull request Feb 27, 2019

Require explicit stabilization of the constness of functions #58775

Closed

Make Unique::as_ptr, NonNull::dangling and NonNull::cast const

797d8ea

Make `Unique::as_ptr` const without feature attribute as it's unstable Make `NonNull::dangling` and `NonNull::cast` const with `feature = "const_ptr_nonnull"`

bors added S-waiting-on-review and removed S-waiting-on-bors labels Mar 4, 2019

bors added S-waiting-on-bors and removed S-waiting-on-review labels Mar 4, 2019

bors added S-waiting-on-review and removed S-waiting-on-bors labels Mar 4, 2019

TimDiekmann mentioned this pull request Mar 4, 2019

Spurious "Command exited with code 259" on AppVeyor #58160

Closed

bors added S-waiting-on-bors and removed S-waiting-on-review labels Mar 5, 2019

Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019

Rollup merge of rust-lang#58750 - TimDiekmann:master, r=oli-obk

70c1977

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

Centril mentioned this pull request Mar 9, 2019

Rollup of 14 pull requests #59043

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019

Rollup merge of rust-lang#58750 - TimDiekmann:master, r=oli-obk

2485fb3

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

Centril mentioned this pull request Mar 9, 2019

Rollup of 13 pull requests #59046

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019

Rollup merge of rust-lang#58750 - TimDiekmann:master, r=oli-obk

f1e317b

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

Centril mentioned this pull request Mar 9, 2019

Rollup of 13 pull requests #59050

Merged

bors merged commit 60a649e into rust-lang:master Mar 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const #58750

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const #58750

TimDiekmann commented Feb 26, 2019

rust-highfive commented Feb 26, 2019

oli-obk commented Feb 26, 2019

TimDiekmann commented Feb 26, 2019 •

edited

Loading

oli-obk commented Feb 26, 2019

rust-highfive commented Feb 26, 2019

oli-obk Feb 26, 2019

Centril Feb 26, 2019

oli-obk Feb 26, 2019

TimDiekmann Feb 26, 2019

Centril Feb 26, 2019

Centril Feb 26, 2019

oli-obk commented Feb 26, 2019

bors commented Feb 26, 2019

Centril commented Feb 27, 2019

TimDiekmann commented Mar 4, 2019

bors commented Mar 4, 2019

bors commented Mar 4, 2019

TimDiekmann commented Mar 4, 2019 •

edited

Loading

ljedrz commented Mar 4, 2019

bors commented Mar 4, 2019

bors commented Mar 4, 2019

Centril commented Mar 5, 2019

Make Unique::as_ptr, NonNull::dangling and NonNull::cast const #58750

Make Unique::as_ptr, NonNull::dangling and NonNull::cast const #58750

Conversation

TimDiekmann commented Feb 26, 2019

rust-highfive commented Feb 26, 2019

oli-obk commented Feb 26, 2019

TimDiekmann commented Feb 26, 2019 • edited Loading

oli-obk commented Feb 26, 2019

rust-highfive commented Feb 26, 2019

oli-obk Feb 26, 2019

Choose a reason for hiding this comment

Centril Feb 26, 2019

Choose a reason for hiding this comment

oli-obk Feb 26, 2019

Choose a reason for hiding this comment

TimDiekmann Feb 26, 2019

Choose a reason for hiding this comment

Centril Feb 26, 2019

Choose a reason for hiding this comment

Centril Feb 26, 2019

Choose a reason for hiding this comment

oli-obk commented Feb 26, 2019

bors commented Feb 26, 2019

Centril commented Feb 27, 2019

TimDiekmann commented Mar 4, 2019

bors commented Mar 4, 2019

bors commented Mar 4, 2019

TimDiekmann commented Mar 4, 2019 • edited Loading

ljedrz commented Mar 4, 2019

bors commented Mar 4, 2019

bors commented Mar 4, 2019

Centril commented Mar 5, 2019

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const #58750

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const #58750

TimDiekmann commented Feb 26, 2019 •

edited

Loading

TimDiekmann commented Mar 4, 2019 •

edited

Loading