-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix the error reference for LocalKey::try_with #51824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after fixing typo.
src/libstd/thread/local.rs
Outdated
@@ -276,7 +276,7 @@ impl<T: 'static> LocalKey<T> { | |||
/// | |||
/// This will lazily initialize the value if this thread has not referenced | |||
/// this key yet. If the key has been destroyed (which may happen if this is called | |||
/// in a destructor), this function will return a `ThreadLocalError`. | |||
/// in a destructor), this function will return a [`AccessError`](struct.AccessError.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"an" AccessError.
@bors r+ rollup |
📌 Commit 771748d has been approved by |
…=kennytm Fix the error reference for LocalKey::try_with There's no such thing as `ThreadLocalError` and the method obviously returns `AccessError`, so adjusting (probably only outdated docs).
Rollup of 7 pull requests Successful merges: - #49987 (Add str::split_ascii_whitespace.) - #50342 (Document round-off error in `.mod_euc()`-method, see issue #50179) - #51658 (Only do sanity check with debug assertions on) - #51799 (Lower case some feature gate error messages) - #51800 (Add a compiletest header for edition) - #51824 (Fix the error reference for LocalKey::try_with) - #51842 (Document that Layout::from_size_align does not allow align=0) Failed merges: r? @ghost
There's no such thing as
ThreadLocalError
and the method obviously returnsAccessError
, so adjusting (probably only outdated docs).