Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expansion info to crate metadata #43847

Closed
wants to merge 13 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed one possible error source when encoding hygiene metadata.
Sadly, this isn't the reason the tests fail.
  • Loading branch information
ibabushkin committed Oct 7, 2017
commit 64934bab20b25ea6f58724b6c90de47c63de56cc
3 changes: 3 additions & 0 deletions src/librustc/middle/cstore.rs
Original file line number Diff line number Diff line change
@@ -253,6 +253,8 @@ pub struct ExternBodyNestedBodies {
pub trait CrateStore {
fn crate_data_as_rc_any(&self, krate: CrateNum) -> Rc<Any>;

fn ensure_hygiene_data_loaded(&self);

// access to the metadata loader
fn metadata_loader(&self) -> &MetadataLoader;

@@ -325,6 +327,7 @@ pub struct DummyCrateStore;
impl CrateStore for DummyCrateStore {
fn crate_data_as_rc_any(&self, krate: CrateNum) -> Rc<Any>
{ bug!("crate_data_as_rc_any") }
fn ensure_hygiene_data_loaded(&self) { bug!("ensure_hygiene_data_loaded") }
// item info
fn visibility_untracked(&self, def: DefId) -> ty::Visibility { bug!("visibility") }
fn item_generics_cloned_untracked(&self, def: DefId) -> ty::Generics
6 changes: 6 additions & 0 deletions src/librustc_metadata/cstore_impl.rs
Original file line number Diff line number Diff line change
@@ -350,6 +350,12 @@ impl CrateStore for cstore::CStore {
self.get_crate_data(krate)
}

fn ensure_hygiene_data_loaded(&self) {
self.iter_crate_data(|_, metadata| {
(*metadata).imported_hygiene_data();
});
}

fn metadata_loader(&self) -> &MetadataLoader {
&*self.metadata_loader
}
2 changes: 1 addition & 1 deletion src/librustc_metadata/decoder.rs
Original file line number Diff line number Diff line change
@@ -1271,6 +1271,6 @@ impl<'a, 'tcx> CrateMetadata {
Some(hygiene::extend_hygiene_data(external_hygiene_data));
self.hygiene_data_being_decoded.set(false);

Ref::map(self.hygiene_data_import_info.borrow(), |d| d.as_ref().unwrap());
Ref::map(self.hygiene_data_import_info.borrow(), |d| d.as_ref().unwrap())
}
}
1 change: 1 addition & 0 deletions src/librustc_metadata/encoder.rs
Original file line number Diff line number Diff line change
@@ -324,6 +324,7 @@ impl<'a, 'tcx> EncodeContext<'a, 'tcx> {
}

fn encode_hygiene_data(&mut self) -> Lazy<hygiene::HygieneData> {
self.tcx.sess.cstore.ensure_hygiene_data_loaded();
hygiene::HygieneData::safe_with(|data| self.lazy(data))
}