-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Updated docker images to share scripts #43129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #42201 |
Is it possible that you forgot to commit the actual scripts? At least I can't find them in the Github diff. |
I did forget to push them, whoops. I just pushed them and then tried to squash the commits, but I don't think I'm squashing them correctly since it shows 3 commits that's trying to merge. |
@Ophirr33: The easiest thing is probably to just do a |
Got it, thanks for the help @TimNN! |
What's the status of this? Are you waiting for @malbarbo to review this? |
He does not even have r? rights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ophirr33!
src/ci/docker/armhf-gnu/Dockerfile
Outdated
RUN curl -o /usr/local/bin/sccache \ | ||
https://s3.amazonaws.com/rust-lang-ci/rust-ci-mirror/2017-05-12-sccache-x86_64-unknown-linux-musl && \ | ||
chmod +x /usr/local/bin/sccache | ||
# dumb-init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok to remove these comments, I don't think they necessarily add much to what's already written down
@@ -0,0 +1,36 @@ | |||
# Copyright 2017 The Rust Project Developers. See the COPYRIGHT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind renaming this to include the term "cross" in the script name? I think this list of packages is mostly suitable for building crosstool-ng and such and running that inside the container.
@alexcrichton Done! |
@bors: r+ |
📌 Commit 2503461 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Attempts to resolve #42201. I managed to pull out five scripts (android-base-apt-get, ubuntu16-apt-get, make3, rustbuild-setup, and crosstool-ng). Let me know if there's more I can do or if I should change some names.
r? @malbarbo