Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple broken links to the reference from error messages. #42624

Closed
wants to merge 1 commit into from
Closed

Fix a couple broken links to the reference from error messages. #42624

wants to merge 1 commit into from
+2 −2

Conversation

frewsxcv
Copy link
Member

No description provided.

@frewsxcv frewsxcv added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2017
GuillaumeGomez
GuillaumeGomez reviewed Jun 13, 2017
View reviewed changes
src/librustc_typeck/diagnostics.rs
@@ -851,7 +851,7 @@ optional namespacing), a dereference, an indexing expression or a field
reference.
More details can be found here:
https://doc.rust-lang.org/reference.html#lvalues-rvalues-and-temporaries
https://doc.rust-lang.org/reference/expressions.html#lvalues-rvalues-and-temporaries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Longer than 80 characters. It fails tidy test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I fix this? Should I have tidy ignore this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the correct fix here is to change https://github.com/rust-lang/rust/blob/master/src/tools/tidy/src/style.rs#L55 to properly handle URLs in non-comment lines. I haven't looked into the exact fix, though. It might be non-trivial.

@GuillaumeGomez
Copy link
Member

Once tidy issue fixed, r=me.

@arielb1 arielb1 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2017
@alexcrichton
Copy link
Member

ping @frewsxcv, just wanted to keep this on your radar!

@frewsxcv
Copy link
Member Author

Still on my radar, just haven't had time to look into modifying the tidy checker.

@shepmaster
Copy link
Member

Pinging @frewsxcv for your weekly heartbeat 💓 ping

@frewsxcv
Copy link
Member Author

frewsxcv commented Jul 1, 2017

I'm here. Haven't had time to look into this. I'm dealing with family issues right now and probably won't get to this anytime soon. Want me to close this and open a GitHub issue?

@aidanhs
Copy link
Member

aidanhs commented Jul 5, 2017

Hi @frewsxcv, bit unfortunate this has turned into a bit of a yak shave!

If 'soon' means a couple of weeks then closing this and opening an issue (referencing this PR as guidance for any future contributor) is probably better, otherwise keeping it around sounds fine. Up to you!

@frewsxcv frewsxcv mentioned this pull request Jul 5, 2017
Closed
@frewsxcv
Copy link
Member Author

frewsxcv commented Jul 5, 2017 •
edited
Loading

Opened #43070

@frewsxcv frewsxcv closed this Jul 5, 2017
@frewsxcv frewsxcv deleted the frewsxcv/errorlinks branch July 5, 2017 18:15
@durka durka mentioned this pull request Jul 5, 2017
Merged
bors added a commit that referenced this pull request Jul 8, 2017
@bors
Auto merge of #43075 - durka:error-long-link, r=nikomatsakis
720c596 
Fix links for typeck diagnostics without tripping tidy

Pick up #42624 to fix #43070 (cc @frewsxcv). I fixed a few other links while I was at it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez

@Mark-Simulacrum Mark-Simulacrum

@QuietMisdreavus QuietMisdreavus

Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@frewsxcv @GuillaumeGomez @alexcrichton @shepmaster @aidanhs @Mark-Simulacrum @arielb1