Add error explaination for E0182, E0230 and E0399 #37244

senior · 2016-10-18T05:07:00Z

This PR adds some error descriptions requested in issue #32777.

Specifically this adds descriptions for

E0182 - unexpected binding of associated item in expression path
E0230 - missing type parameter from on_unimplemented description
E0399 - overriding a trait type without re-implementing default methods

rust-highfive · 2016-10-18T05:07:16Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez · 2016-10-18T09:47:16Z

src/librustc_typeck/diagnostics.rs

@@ -1915,6 +1915,47 @@ More details can be found in [RFC 438].
 [RFC 438]: https://github.com/rust-lang/rfcs/pull/438
 "##,

+E0182: r##"
+You bound an associated type in an expression path which is not
+allowed. Erroneous code example:


"Erroneous code example" sentence needs to be on its own line.

GuillaumeGomez · 2016-10-18T09:47:54Z

src/librustc_typeck/diagnostics.rs

+    fn bar() -> isize { 42 }
+}
+
+pub fn main() {


It's better to avoid putting the main function in the examples.

Are you thinking it would be better to just have that line floating after the trait impl?

trait Foo { type A; fn bar() -> isize; } impl Foo for isize { type A = usize; fn bar() -> isize { 42 } } // error: unexpected binding of associated item in expression path let x: isize = Foo::<A=usize>::bar();

Yes. The point is to avoid any unneeded "noise". Everyone knows that code needs to go inside a function and it's not what we're trying to do in here. In the generated output, everything (or almost) is put inside a main function so don't worry about it.

You didn't fix this one.

GuillaumeGomez · 2016-10-18T09:48:39Z

src/librustc_typeck/diagnostics.rs

@@ -2752,6 +2793,28 @@ fn main() {
 ```
 "##,

+E0230: r##"
+The trait has more type parameters specified than appear in it's definition.


GuillaumeGomez · 2016-10-18T09:48:50Z

src/librustc_typeck/diagnostics.rs

@@ -2752,6 +2793,28 @@ fn main() {
 ```
 "##,

+E0230: r##"
+The trait has more type parameters specified than appear in it's definition.
+Erroneous example code:


Missing empty line before this one.

GuillaumeGomez · 2016-10-18T09:49:30Z

src/librustc_typeck/diagnostics.rs

+{}
+```
+
+Include the correct number of type params and compilation should proceed:


"params" -> "parameters"
"compilation" -> "the compilation" (I find it better this way but totally open to debate)

GuillaumeGomez · 2016-10-18T09:49:49Z

src/librustc_typeck/diagnostics.rs

@@ -3567,6 +3630,42 @@ fn together_we_will_rule_the_galaxy(son: &A<i32>) {} // Ok!
 ```
 "##,

+E0399: r##"
+You implemented a trait, overriding one or more of it's associated types but did


GuillaumeGomez · 2016-10-18T09:49:56Z

src/librustc_typeck/diagnostics.rs

@@ -3567,6 +3630,42 @@ fn together_we_will_rule_the_galaxy(son: &A<i32>) {} // Ok!
 ```
 "##,

+E0399: r##"
+You implemented a trait, overriding one or more of it's associated types but did
+not reimplement it's default methods. Example of erroneous code:


GuillaumeGomez · 2016-10-18T09:50:25Z

src/librustc_typeck/diagnostics.rs

+}
+```
+
+Add an implementation for the default methods:


The explanation isn't really explaining anything in here. :-/

Maybe "To fix this, add an implementation for each default method from the trait:"?

GuillaumeGomez · 2016-10-18T09:51:12Z

src/librustc_typeck/diagnostics.rs

+}
+```
+
+To give a concrete type when using the Universal Function Call Syntax,


I wonder if there are enough details or not... Hard to say from my point of view... :-/

What do you think of this @steveklabnik ?

GuillaumeGomez · 2016-10-18T09:52:00Z

Thanks for your work! Just a few typos/nits/improvements and it should be good. :)

senior · 2016-10-21T03:05:18Z

@GuillaumeGomez Just pushed up another commit with the fixes

GuillaumeGomez · 2016-10-21T09:33:11Z

All good, thanks again!

@bors: r+ rollup

bors · 2016-10-21T09:33:12Z

📌 Commit 94c1220 has been approved by GuillaumeGomez

GuillaumeGomez · 2016-10-21T09:33:41Z

@bors: r-

GuillaumeGomez · 2016-10-21T09:33:53Z

src/librustc_typeck/diagnostics.rs

+    fn bar() -> isize { 42 }
+}
+
+pub fn main() {


You didn't fix this one.

GuillaumeGomez · 2016-10-21T09:34:34Z

src/librustc_typeck/diagnostics.rs

@@ -3567,6 +3632,42 @@ fn together_we_will_rule_the_galaxy(son: &A<i32>) {} // Ok!
 ```
 "##,

+E0399: r##"
+You implemented a trait, overriding one or more of its associated types but did
+not reimplement its default methods. Example of erroneous code:


"Example of erroneous code example" should be on its own line.

D'oh, good catch.

GuillaumeGomez · 2016-10-21T09:36:13Z

Sorry, missed remaining things... Also, once done, can you squash the extra commits please (just keep the 3 first ones). If you don't know how to do it, take a look here.

senior · 2016-10-21T12:27:53Z

@GuillaumeGomez No problem, I must have missed that. I fixed up the original 3 commits to include the fixes.

GuillaumeGomez · 2016-10-21T23:21:39Z

Ok, now it's good! Thanks again. :)

@bors: r+ rollup

bors · 2016-10-21T23:21:40Z

📌 Commit 9365586 has been approved by GuillaumeGomez

@GuillaumeGomez

…r=GuillaumeGomez Add error explaination for E0182, E0230 and E0399 This PR adds some error descriptions requested in issue rust-lang#32777. r? @GuillaumeGomez Specifically this adds descriptions for E0182 - unexpected binding of associated item in expression path E0230 - missing type parameter from on_unimplemented description E0399 - overriding a trait type without re-implementing default methods

Rollup of 10 pull requests - Successful merges: #37043, #37209, #37211, #37219, #37244, #37253, #37286, #37297, #37309, #37314 - Failed merges:

rust-highfive assigned GuillaumeGomez Oct 18, 2016

GuillaumeGomez requested changes Oct 18, 2016

View reviewed changes

GuillaumeGomez approved these changes Oct 21, 2016

View reviewed changes

GuillaumeGomez requested changes Oct 21, 2016

View reviewed changes

Ryan Senior added 3 commits October 21, 2016 07:23

Add an error explaination for E0182

5402271

Add an error explaination for E0230

e7d01cf

Add an error explaination for E0399

9365586

senior force-pushed the add-error-desc-182-230-399 branch from 94c1220 to 9365586 Compare October 21, 2016 12:25

GuillaumeGomez approved these changes Oct 21, 2016

View reviewed changes

GuillaumeGomez mentioned this pull request Oct 21, 2016

Rollup of 10 pull requests #37337

Merged

bors added a commit that referenced this pull request Oct 22, 2016

Auto merge of #37337 - GuillaumeGomez:rollup, r=GuillaumeGomez

f136e9e

Rollup of 10 pull requests - Successful merges: #37043, #37209, #37211, #37219, #37244, #37253, #37286, #37297, #37309, #37314 - Failed merges:

bors merged commit 9365586 into rust-lang:master Oct 22, 2016

Add error explaination for E0182, E0230 and E0399 #37244

Add error explaination for E0182, E0230 and E0399 #37244

Conversation

senior commented Oct 18, 2016

Uh oh!

rust-highfive commented Oct 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Oct 18, 2016

Uh oh!

senior commented Oct 21, 2016

Uh oh!

GuillaumeGomez commented Oct 21, 2016

Uh oh!

bors commented Oct 21, 2016

Uh oh!

GuillaumeGomez commented Oct 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Oct 21, 2016

Uh oh!

senior commented Oct 21, 2016

Uh oh!

GuillaumeGomez commented Oct 21, 2016

Uh oh!

bors commented Oct 21, 2016

Uh oh!