-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Rehome tests in tests/ui/
to accurate subdirectories
#142808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The illegal-sized-bounds
directory is apparently meant for errors caused by trying to call methods on trait objects which are disabled via where Self: Sized
— pretty niche (its entire content should be moved into the dyn-compatibility/
directory, probably).
I would move this test into trait-bounds/
. Coincidentally I touched that file an hour ago in PR #142693, that's why I'm commenting on this at all.
I think larger batches of plain move PRs are fine, both for git blame purposes (plain moves are handled well) and review purposes. I would probably avoid changing test content in plain-move PRs tho. |
Yeah, I'll look at these test move PRs next week together. If your PR had the moves for specific tests first, we'll land those and drop them from this PR. |
double-ref, deref, inlined-main and else-if This ones already were moved by me, so afaiu we should remove it from here? Btw, I opened random test here (https://github.com/rust-lang/rust/blob/199804aa799221bc8cb569446dddfbe8c4cac8bd/tests/ui/typeck/tail-typeck.rs) Do we really want to keep this one? I'd rather delete it |
Part of #133895 and the 2025 Google Summer of Code associated project.
tests/ui/
contains many top level tests without a "category", despite belonging in one of the subdirectories within. This pull request aims to reorganize top-level tests in accurate categories, according to the guidelines established by #141597.Set to draft until it is decided whether it is better to release these PRs in one single large one, or multiple smaller ones for ease of reviewing.
The test
double-ref.rs
was also changed to becheck-pass
, as it does not execute any code at runtime.r? @jieyouxu