Emit a single error when importing a path with _
#142805
Open
+66
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering `use _;`, `use _::*'` or similar, do not emit two errors for that single mistake. This also side-steps the issue of resolve errors suggesting adding a crate named `_` to `Cargo.toml`.
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Jun 20, 2025
| @@ -711,6 +711,12 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> { | |||
|
|
|||
| let mut diag = struct_span_code_err!(self.dcx(), span, E0432, "{msg}"); | |||
|
|
|||
| if errors.iter().all(|(_, err)| err.segment == Some(kw::Underscore)) { | |||
There was a problem hiding this comment.
This leads to inconsistent behavior in code like use {_, a}. I'd rather we filter out the errors mentioning _ like we're doing with that errors.retain call above.
There was a problem hiding this comment.
And while we're at it, we probably should delay a bug in the:
if errors.is_empty() {
return;
}
on 691.
Kivooeo
reviewed
Jun 21, 2025
There was a problem hiding this comment.
Since this pr touches this test, could we also rename it with some more descriptive name and put a small comment with a link on an issue related to this instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering
use _;,use _::*'or similar, do not emit two errors for that single mistake. This also side-steps the issue of resolve errors suggesting adding a crate named_toCargo.toml.Fix #142662.