Skip to content

Rename LayoutS to LayoutData in comments #142804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zachs18
Copy link
Contributor

@zachs18 zachs18 commented Jun 20, 2025

LayoutS was renamed to LayoutData, but some comments in the compiler were not changed. This updates comments in the compiler (and one section of commented-out code in rust-analyzer) to refer to LayoutData instead of LayoutS.

cc #132252, @workingjubilee

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

r? @saethlin

rustbot has assigned @saethlin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@saethlin
Copy link
Member

Checks out
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 20, 2025

📌 Commit a7ff98e has been approved by saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2025
@workingjubilee
Copy link
Member

Thanks!

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 21, 2025
…ta-in-comments, r=saethlin

Rename `LayoutS` to `LayoutData` in comments

`LayoutS` was renamed to `LayoutData`, but some comments in the compiler were not changed. This updates comments in the compiler (and one section of commented-out code in rust-analyzer) to refer to `LayoutData` instead of `LayoutS`.

cc <rust-lang#132252>, `@workingjubilee`
bors added a commit that referenced this pull request Jun 21, 2025
Rollup of 7 pull requests

Successful merges:

 - #142502 (rustdoc_json: improve handling of generic args)
 - #142597 (error on calls to ABIs that cannot be called)
 - #142785 (fix(linkcheck): Build using the lockfile)
 - #142787 (Add diagnostic items for Clippy)
 - #142788 (add doc(alias("AsciiChar")) to core::ascii::Char)
 - #142801 (Use gen blocks in the compiler instead of `from_coroutine`)
 - #142804 (Rename `LayoutS` to `LayoutData` in comments)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants