Encode hir attributes cross-crate properly

[jdonszelmann]

r? @oli-obk

This should return the lost perf in #138165

cc: @therealprof

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a1e655d with merge 3d3aa78...

[bors]

☀️ Try build successful - checks-actions
Build commit: 3d3aa78 (3d3aa7894aface06da60fe7023a7ad0455576db7)

[rust-timer]

Finished benchmarking commit (3d3aa78): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	13
Improvements ✅ (secondary)	-0.6%	[-0.8%, -0.2%]	20
All ❌✅ (primary)	-0.1%	[-0.8%, 2.7%]	14

Max RSS (memory usage)

Results (primary -1.3%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.2%]	3
Improvements ✅ (secondary)	-2.0%	[-3.0%, -0.7%]	12
All ❌✅ (primary)	-1.3%	[-1.4%, -1.2%]	3

Cycles

Results (primary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Binary size

Results (primary -0.1%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.6%, -0.0%]	85
Improvements ✅ (secondary)	-0.2%	[-0.8%, -0.0%]	40
All ❌✅ (primary)	-0.1%	[-0.6%, 1.1%]	86

Bootstrap: 691.482s -> 692.142s (0.10%)
Artifact size: 371.94 MiB -> 371.94 MiB (0.00%)

[oli-obk]

@bors r+

[bors]

📌 Commit a1e655d has been approved by oli-obk

It is now in the queue for this repository.

[therealprof]

@jdonszelmann Sweet, thanks for looking into it.

[jdonszelmann]

still don't get the +2.7% on clap