Introduce debuginfo to statements in MIR #142771

dianqk · 2025-06-20T07:16:46Z

Not ready for reviewing. Something known:

Retain debuginfo when concatenating bbs
Document about when to drop debuginfos (don't be worse than the optimized LLVM IR)
Missing tests

r? ghost

compiler/rustc_middle/src/mir/mod.rs

dianqk · 2025-06-20T10:52:57Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-20T10:53:00Z

⌛ Trying commit 51576e7 with merge eb83156…

To cancel the try build, run the command @bors2 try cancel.

Introduce debuginfo to statements in MIR Not ready for reviewing. Something known: - [ ] Retain debuginfo when concatenating bbs - [ ] Document about when to drop debuginfos (don't be worse than the optimized LLVM IR) - [ ] Missing tests r? ghost

rust-bors · 2025-06-20T13:23:31Z

☀️ Try build successful (CI)
Build commit: eb83156 (eb83156169ae3bbdd1385d498455dbc44283f5ff, parent: 18491d5be00eb3ed2f1ccee2ac5b792694f2a7a0)

rust-timer · 2025-06-20T23:32:50Z

Finished benchmarking commit (eb83156): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.2%, 14.5%]	51
Regressions ❌ (secondary)	0.8%	[0.1%, 1.6%]	52
Improvements ✅ (primary)	-0.4%	[-2.1%, -0.2%]	35
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.2%]	39
All ❌✅ (primary)	0.4%	[-2.1%, 14.5%]	86

Max RSS (memory usage)

Results (primary 2.3%, secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[0.8%, 4.7%]	54
Regressions ❌ (secondary)	3.6%	[0.7%, 7.4%]	38
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	2.3%	[0.8%, 4.7%]	54

Cycles

Results (primary 3.2%, secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.9%	[1.1%, 14.4%]	7
Regressions ❌ (secondary)	2.5%	[2.0%, 3.3%]	3
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[-2.0%, 14.4%]	8

Binary size

Results (primary 0.5%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.0%, 2.2%]	123
Regressions ❌ (secondary)	1.1%	[0.0%, 3.5%]	59
Improvements ✅ (primary)	-0.9%	[-6.5%, -0.1%]	11
Improvements ✅ (secondary)	-0.5%	[-13.0%, -0.1%]	55
All ❌✅ (primary)	0.5%	[-6.5%, 2.2%]	134

Bootstrap: 691.482s -> 692.445s (0.14%)
Artifact size: 371.94 MiB -> 372.12 MiB (0.05%)

Avoid introducing a large number of changes when adding optional initialization fields.

`-Copt-level=0` (`-Zmir-opt-level=1`) is preferred for debugging.

This reverts commit b28d4ec.

dianqk · 2025-06-21T02:59:42Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-21T02:59:46Z

⌛ Trying commit e72c3ae with merge 77d5c6a…

To cancel the try build, run the command @bors2 try cancel.

Introduce debuginfo to statements in MIR Not ready for reviewing. Something known: - [ ] Retain debuginfo when concatenating bbs - [ ] Document about when to drop debuginfos (don't be worse than the optimized LLVM IR) - [ ] Missing tests r? ghost

rust-log-analyzer · 2025-06-21T03:15:04Z

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#19 exporting to docker image format
#19 sending tarball 27.1s done
#19 DONE 34.5s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-19]
[CI_JOB_NAME=x86_64-gnu-llvm-19]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-19', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--set', 'gcc.download-ci-gcc=true', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-19/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
---- [mir-opt] tests/mir-opt/inline/inline_diverging.rs stdout ----

error: compilation failed!
status: exit status: 101
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/mir-opt/inline/inline_diverging.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "-Copt-level=1" "-Zdump-mir=Inline | Inline | Inline" "-Zvalidate-mir" "-Zlint-mir" "-Zdump-mir-exclude-pass-number" "-Zmir-include-spans=false" "--crate-type=rlib" "-Zmir-opt-level=4" "-Zmir-enable-passes=+ReorderBasicBlocks,+ReorderLocals" "-Zdump-mir-dir=/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/inline/inline_diverging" "--emit" "mir" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/inline/inline_diverging" "-A" "internal_features" "-Crpath" "-Zinline-mir-hint-threshold=1000" "-C" "debuginfo=full"
stdout: none
--- stderr -------------------------------
invalid expression
!DIExpression(4096, 0, 32, 159)
rustc-LLVM ERROR: Broken module found, compilation aborted!

rust-bors · 2025-06-21T05:28:30Z

☀️ Try build successful (CI)
Build commit: 77d5c6a (77d5c6a20a77fabdee3790a412618b82178e9ab4, parent: 15c701fbc995eb6c5b3a86021c18185f8eee020d)

rust-timer · 2025-06-21T09:26:06Z

Finished benchmarking commit (77d5c6a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.1%, 14.5%]	53
Regressions ❌ (secondary)	0.8%	[0.1%, 1.6%]	50
Improvements ✅ (primary)	-0.4%	[-3.0%, -0.2%]	46
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.2%]	41
All ❌✅ (primary)	0.3%	[-3.0%, 14.5%]	99

Max RSS (memory usage)

Results (primary 2.4%, secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[0.5%, 5.7%]	38
Regressions ❌ (secondary)	4.2%	[1.3%, 6.2%]	25
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-3.0%, -1.1%]	4
All ❌✅ (primary)	2.4%	[0.5%, 5.7%]	38

Cycles

Results (primary 2.1%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[0.8%, 14.1%]	10
Regressions ❌ (secondary)	3.3%	[2.3%, 4.3%]	2
Improvements ✅ (primary)	-2.3%	[-2.9%, -1.7%]	2
Improvements ✅ (secondary)	-2.2%	[-2.6%, -1.9%]	2
All ❌✅ (primary)	2.1%	[-2.9%, 14.1%]	12

Binary size

Results (primary 0.5%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.0%, 3.0%]	122
Regressions ❌ (secondary)	1.1%	[0.0%, 3.5%]	59
Improvements ✅ (primary)	-0.7%	[-4.9%, -0.0%]	15
Improvements ✅ (secondary)	-0.5%	[-12.7%, -0.0%]	55
All ❌✅ (primary)	0.5%	[-4.9%, 3.0%]	137

Bootstrap: 690.617s -> 691.47s (0.12%)
Artifact size: 371.83 MiB -> 372.01 MiB (0.05%)

rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 20, 2025

This comment has been minimized.

Sign in to view

dianqk force-pushed the mir-stmt-debuginfo branch from 15c968a to 6b013d4 Compare June 20, 2025 08:01

This comment has been minimized.

Sign in to view

bjorn3 reviewed Jun 20, 2025

View reviewed changes

compiler/rustc_middle/src/mir/mod.rs Show resolved Hide resolved

dianqk force-pushed the mir-stmt-debuginfo branch from 6b013d4 to 51576e7 Compare June 20, 2025 09:23

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 20, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 20, 2025

dianqk added 10 commits June 21, 2025 10:24

mir: Add a new method to statement

2428057

Avoid introducing a large number of changes when adding optional initialization fields.

mir: Use the new method for BasicBlockData

dc2b959

mir: Introduce an empty StmtDebugInfo

58e9d75

mir-opt: Eliminate dead ref statements

7986f6c

mir-opt: Eliminate trivial unnecessary storage annotations

9f50f84

codegen: Generate dbg_value for the ref statement

395abf8

mir-opt: Eliminate statements need debuginfo when mir-opt-level >= 2

ff0424c

`-Copt-level=0` (`-Zmir-opt-level=1`) is preferred for debugging.

inline: Drop debuginfos if drop var debuginfos

b28d4ec

Revert "inline: Drop debuginfos if drop var debuginfos"

e3c0f1b

This reverts commit b28d4ec.

test: Try to keep the original cost

e72c3ae

dianqk force-pushed the mir-stmt-debuginfo branch from 51576e7 to e72c3ae Compare June 21, 2025 02:31

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 21, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Introduce debuginfo to statements in MIR #142771

Introduce debuginfo to statements in MIR #142771

dianqk commented Jun 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

dianqk commented Jun 20, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 20, 2025

Uh oh!

rust-bors bot commented Jun 20, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 20, 2025

Uh oh!

dianqk commented Jun 21, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 21, 2025

Uh oh!

rust-log-analyzer commented Jun 21, 2025

Uh oh!

rust-bors bot commented Jun 21, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 21, 2025

Uh oh!

Uh oh!

Introduce debuginfo to statements in MIR #142771

Are you sure you want to change the base?

Introduce debuginfo to statements in MIR #142771

Conversation

dianqk commented Jun 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

dianqk commented Jun 20, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 20, 2025

Uh oh!

rust-bors bot commented Jun 20, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 20, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

dianqk commented Jun 21, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 21, 2025

Uh oh!

rust-log-analyzer commented Jun 21, 2025

Uh oh!

rust-bors bot commented Jun 21, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 21, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Uh oh!