Make Clone a const_trait
#142756
Merged
Make Clone a const_trait
#142756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
3 tasks
Daniel-Aaron-Bloom
force-pushed
the
const-clone
branch
from
bb9aeda to
f942fef
Compare
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Cc @rust-lang/wg-const-eval |
|
cc @rust-lang/project-const-traits |
Daniel-Aaron-Bloom
force-pushed
the
const-clone
branch
from
f942fef to
9185143
Compare
oli-obk
reviewed
Jun 20, 2025
| @@ -157,6 +157,8 @@ mod uninit; | |||
| #[lang = "clone"] | |||
| #[rustc_diagnostic_item = "Clone"] | |||
| #[rustc_trivial_field_reads] | |||
| #[rustc_const_unstable(feature = "const_clone", issue = "142757")] | |||
There was a problem hiding this comment.
I dont think we need per trait gates? Seems like it could cause ppl to add lots of feature gates. And we can stabilize individual const traits without stabilizing the full set either way. Library feature gates are funny this way
There was a problem hiding this comment.
Ah looks like this is how we did it before, too. Let's keep doing that
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 21, 2025
Rollup of 8 pull requests Successful merges: - #142384 (Bringing `rustc_rayon_core` in tree as `rustc_thread_pool`) - #142476 (Insert parentheses around binary operation with attribute) - #142485 (Marks ADT live if it appears in pattern) - #142571 (Reason about borrowed classes in CopyProp.) - #142677 (Add CI check to ensure that rustdoc JSON `FORMAT_VERSION` is correctly updated) - #142716 (Adjust `with_generic_param_rib`.) - #142756 (Make `Clone` a `const_trait`) - #142765 (rustc_target: document public AbiMap-related fn and variants) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tracking issue for justification.