rework #[naked] attribute parser
#142493
Open
rework #[naked] attribute parser
#142493
+261
−195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
9 tasks
jdonszelmann
force-pushed
the
naked
branch
2 times, most recently
from
48b6d12 to
78a8771
Compare
This comment has been minimized.
This comment has been minimized.
|
cc: @folkertdev this might interest you |
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #142795) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
|
Some changes occurred in compiler/rustc_codegen_ssa |
rustbot
added
the
S-waiting-on-review
oli-obk
reviewed
Jun 21, 2025
Comment on lines
128
to
130
| let Some(span) = self.span else { | ||
| return None; | ||
| }; |
oli-obk
reviewed
Jun 21, 2025
| // only if we found a naked attribute do we do the somewhat expensive check | ||
| 'outer: for other_attr in cx.all_attrs { | ||
| for allowed_attr in ALLOW_LIST { | ||
| if other_attr.word_is(*allowed_attr) || other_attr.starts_with(&[sym::rustfmt]) { |
There was a problem hiding this comment.
is clippy using custom tool attrs nowadays? May be good to ignore those, too
There was a problem hiding this comment.
could also move the rustfmt check out of the loop
oli-obk
reviewed
Jun 21, 2025
|
|
||
| /// A list of all attribute on this syntax node. | ||
| /// | ||
| /// Useful for allowlists in finalize. |
There was a problem hiding this comment.
Useful for compatibility checks with other attributes in finalize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk