Add test cases for namespaced crates #142437
Conversation
rustbot
added
S-waiting-on-review
|
|
||
| //@ ignore-test FIXME(packages_as_namespaces): feature not implemented yet | ||
|
|
||
| use my_api; // FIXME can be resolved even though it (maybe?) shouldn't be |
There was a problem hiding this comment.
| use my_api; // FIXME can be resolved even though it (maybe?) shouldn't be | |
| use my_api; |
We should decide the desired behavior before merging this. In this test case, my_api is an open namespace module. I think it makes sense to resolve it, as it's fine to have a module that only contains another module.
There was a problem hiding this comment.
Yeah, this should generally work, unless there are specific reasons for not supporting it (like issues with reexporting things like this to other crates due to them lacking identity).
|
|
||
| use my_api::core::{core_fn, core_fn2}; | ||
| use my_api::utils::*; | ||
| use my_api::*; |
There was a problem hiding this comment.
In the 3-scope model this would import from both my_api(crate) and my_api(open_ns).
Therefore it will introduce names root_function, core and utils into this module.
Need to test this behavior.
Old comment (based on mixing open-ns-my_api.rs and open-ns-mod-my_api.rs):
Therefore it will introduce names
utils(mod),root_functionandcoreinto this module, but notutils(crate)because it would be shadowed byutils(mod).
It would be good to actually add a test case with scenario like that.
| @@ -0,0 +1,18 @@ | |||
| // This test should fail with `utils` being defined multiple times, since open-ns-mod-my_api.rs | |||
There was a problem hiding this comment.
Hm? There's no open-ns-mod-my_api.rs in this test.
|
|
||
| //@ ignore-test FIXME(packages_as_namespaces): feature not implemented yet | ||
|
|
||
| use my_api; // FIXME can be resolved even though it (maybe?) shouldn't be |
There was a problem hiding this comment.
Yeah, this should generally work, unless there are specific reasons for not supporting it (like issues with reexporting things like this to other crates due to them lacking identity).
petrochenkov
added
S-waiting-on-author
This is just to add a few test cases of agreed upon desired behavior for this feature so that future PRs can enable them as they start passing.
I pulled these tests out of #140271.
r? @petrochenkov
cc @b-naber