Add From<{integer}> for f16/f128 impls
#138363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
beetrees
force-pushed
the
f16-f128-integer-convert
branch
from
8767c41 to
7c07265
Compare
|
Obligatory crater run since we've had trouble with f16/f128 stdlib impls in the past :) edit: oh i just read that you also asked for a crater run; yep, agreed lol @bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2025
…=<try>
Add `From<{integer}>` for `f16`/`f128` impls
This PR adds `impl From<{bool,i8,u8}> for f16` and `impl From<{bool,i8,u8,i16,u16,i32,u32}> for f128`.
The `From<{i64,u64}> for f128` impls are left commented out as adding them would allow using `f128` on stable before it is stabilised like in the following example:
```rust
fn f<T: From<u64>>(x: T) -> T { x }
fn main() {
let x = f(1.0); // the type of the literal is inferred to be `f128`
}
```
None of the impls added in this PR have this issue as they are all, at minimum, also implemented by `f64`.
This PR will need a crater run for the `From<{i32,u32}>` impls, as `f64` is no longer the only float type to implement them (similar to the cause of rust-lang#125198).
cc `@bjoernager`
r? `@tgross35`
Tracking issue: rust-lang#116909
|
☀️ Try build successful - checks-actions |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
This LGTM assuming crater is okay, but somebody from libs-api will need to approve r? @Amanieu |
tgross35
added
F-f16_and_f128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
impl From<{bool,i8,u8}> for f16andimpl From<{bool,i8,u8,i16,u16,i32,u32}> for f128.The
From<{i64,u64}> for f128impls are left commented out as adding them would allow usingf128on stable before it is stabilised like in the following example:None of the impls added in this PR have this issue as they are all, at minimum, also implemented by
f64.This PR will need a crater run for the
From<{i32,u32}>impls, asf64is no longer the only float type to implement them (similar to the cause of #125198).cc @bjoernager
r? @tgross35
Tracking issue: #116909