Improve -Z crate-attr diagnostics
#138336
Open
+174
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vadim Petrochenkov <[email protected]>
rustbot
added
S-waiting-on-review
jyn514
force-pushed
the
crate-attr-diagnostics
branch
from
5e4599d to
2d05a27
Compare
rustbot
removed
the
T-bootstrap
jyn514
force-pushed
the
crate-attr-diagnostics
branch
2 times, most recently
from
7fc52b8 to
74e6e2d
Compare
4 tasks
This comment has been minimized.
This comment has been minimized.
- Move `crate-attr` parsing from `rustc_builtin_macros` to `rustc_parse`. This is not a built-in macro. - Show the `#![ ... ]` in the span (to make it clear that it should not be included in the CLI argument) - Show more detailed errors when the crate has valid token trees but invalid syntax. Previously, `crate-attr=feature(foo),feature(bar)` would just say "invalid crate attribute" and point at the comma. Now, it explicitly says that the comma was unexpected, which is useful when using `--error-format=short`. It also fixes the column to show the correct span. - Recover from parse errors. Previously we would abort immediately on syntax errors; now we go on to try and type-check the rest of the crate. The new diagnostic code also happens to be slightly shorter.
jyn514
force-pushed
the
crate-attr-diagnostics
branch
from
74e6e2d to
4b25b06
Compare
All kind of code injected by rustc consistently lives in |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
bjorn3
reviewed
Mar 11, 2025
| @@ -0,0 +1,3 @@ | |||
| //@ compile-flags: '-Zcrate-attr=feature(yeet_expr)]fn main(){}#[inline' | |||
There was a problem hiding this comment.
What about -Zcrate-attr=feature(yeet_expr)]#
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crate-attrparsing fromrustc_builtin_macrostorustc_parse. This is not a built-in macro.#![ ... ]in the span (to make it clear that it should notbe included in the CLI argument)
invalid syntax.
Previously,
crate-attr=feature(foo),feature(bar)would just say"invalid crate attribute" and point at the comma. Now, it explicitly
says that the comma was unexpected, which is useful when using
--error-format=short. It also fixes the column to show the correctspan.
syntax errors; now we go on to try and type-check the rest of the
crate.
The new diagnostic code also happens to be slightly shorter.
This builds on #138288; the last commit more clearly shows exactly how this changes diagnostics. You don't have to review the tests themselves (unless you want to i guess ^^ but in that case please leave the review on the other PR).
r? diagnostics