Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RUSTC_LINT_FLAGS more #138331

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use RUSTC_LINT_FLAGS more #138331

wants to merge 3 commits into from
+39 −95

Conversation

nnethercote
Copy link
Contributor

An alternative to the failed #138084.

Fixes #138106.

r? @jieyouxu

@nnethercote
Use RUSTC_LINT_FLAGS more.
c9c8387 
For the `Mode::Rustc` lints as well. Because, unlike `RUSTC_FLAGS`,
`RUSTC_LINT_FLAGS` is not ignored for proc macro crates.

Fixes rust-lang#138106.
@nnethercote
Add unreachable_pub to RUSTC_LINT_FLAGS for compiler/ crates.
55505ab 
And fix the new errors in the handful of crates that didn't have a
`#![warn(unreachable_pub)]`.
@nnethercote
Remove #![warn(unreachable_pub)] from all compiler/ crates.
ff0a5fe 
It's no longer necessary now that `-Wunreachable_pub` is being passed.
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Mar 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_sanitizers

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@nnethercote nnethercote mentioned this pull request Mar 11, 2025
Closed
@jieyouxu
Copy link
Member

Wow, that was added back in #74046.

@jieyouxu
Copy link
Member

This looks like it shouldn't cause problems to me, but also I didn't foresee the rustc-src breakage, so rolling a second bootstrap reviewer to double-check.

r? @onur-ozkan (or reroll)

@rustbot rustbot assigned onur-ozkan and unassigned jieyouxu Mar 11, 2025
jieyouxu
jieyouxu approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  • Compiler changes look good to me.
  • Bootstrap changes LGTM as well but definitely worth having another bootstrap reviewer double-check.

@jieyouxu jieyouxu self-assigned this Mar 11, 2025
onur-ozkan
onur-ozkan approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@onur-ozkan
Copy link
Member

@bors r=onur-ozkan,jieyouxu

@bors
Copy link
Contributor

bors commented Mar 11, 2025

📌 Commit ff0a5fe has been approved by onur-ozkan,jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025
@nnethercote nnethercote mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@jieyouxu jieyouxu

@onur-ozkan onur-ozkan

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate and implement a scheme to consistently apply RUSTFLAGS and lints for all compiler crates
5 participants
@nnethercote @rustbot @jieyouxu @onur-ozkan @bors