Create a generic AVR target: avr-none #131651

Patryk27 · 2024-10-13T13:14:08Z

This commit removes the avr-unknown-gnu-atmega328 target and replaces it with a more generic avr-none variant that must be specialized using -C target-cpu (e.g. -C target-cpu=atmega328p).

Seizing the day, I'm adding myself as the maintainer of this target - I've been already fixing the bugs anyway, might as well make it official 🙂

Related discussions:

try-job: x86_64-gnu-debug

rustbot · 2024-10-13T13:14:16Z

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-10-13T13:14:18Z

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

Some changes occurred in src/tools/compiletest

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

Patryk27 · 2024-10-13T13:14:34Z

cc @workingjubilee?

Patryk27 · 2024-10-13T14:04:13Z

Ouch, I'm not sure why the test is failing - rustc --print=all-target-specs-json -Z unstable-options does return avr-unknown-unknown.

workingjubilee · 2024-10-13T16:43:01Z

my first instinct is "bootstrap problem?"

jieyouxu · 2024-10-13T21:36:50Z

I'll take a look

src/tools/compiletest/src/header/tests.rs

jieyouxu

The test and bootstrap side of things LGTM modulo the compiletest header test thing. Didn't look at the compiler side.

src/doc/rustc/src/platform-support/avr-unknown-unknown.md

tgross35 · 2025-02-19T21:28:53Z

Thanks for the updates, the new implementation looks very clean. Added a try job that I believe runs rmake tests, I think this looks good as long as that passes.

@bors try

bors · 2025-02-19T21:30:06Z

⌛ Trying commit 78ddabf with merge cbf7965...

Create a generic AVR target: avr-none This commit removes the `avr-unknown-gnu-atmega328` target and replaces it with a more generic `avr-none` variant that must be specialized using `-C target-cpu` (e.g. `-C target-cpu=atmega328p`). Seizing the day, I'm adding myself as the maintainer of this target - I've been already fixing the bugs anyway, might as well make it official 🙂 Related discussions: - rust-lang#131171 - rust-lang/compiler-team#800 try-job: x86_64-gnu-debug

tgross35 · 2025-02-19T21:30:59Z

(it's cheating a bit, but should be good for the time being)

Do you just mean using avr as the target CPU?

Patryk27 · 2025-02-19T22:15:43Z

Yeah, that's the cheating part - I couldn't force lld to understand -mmcu / -mcpu / --mmcu / --mcpu, so instead I've adjusted the test's target-cpu to the "minimal" variant (of just the base instruction set) that seems to be lld's default. I'm open to other approaches, just couldn't make it work otherwise myself.

tgross35 · 2025-02-19T23:08:37Z

That seems fine to me for the time being. Mind just adding a comment about that in the rmake test?

bors · 2025-02-19T23:34:57Z

☀️ Try build successful - checks-actions
Build commit: cbf7965 (cbf796516b8283f9824489185badd8a0e2359030)

Patryk27 · 2025-02-20T14:05:31Z

Ready!

tgross35 · 2025-02-20T17:12:17Z

Thanks! Let's get this in.

@bors r+

bors · 2025-02-20T17:12:21Z

📌 Commit d5128f9 has been approved by tgross35

It is now in the queue for this repository.

…ross35 Create a generic AVR target: avr-none This commit removes the `avr-unknown-gnu-atmega328` target and replaces it with a more generic `avr-none` variant that must be specialized using `-C target-cpu` (e.g. `-C target-cpu=atmega328p`). Seizing the day, I'm adding myself as the maintainer of this target - I've been already fixing the bugs anyway, might as well make it official 🙂 Related discussions: - rust-lang#131171 - rust-lang/compiler-team#800 try-job: x86_64-gnu-debug

…kingjubilee Rollup of 14 pull requests Successful merges: - rust-lang#131651 (Create a generic AVR target: avr-none) - rust-lang#136473 (infer linker flavor by linker name if it's sufficiently specific) - rust-lang#136608 (Pass through of target features to llvm-bitcode-linker and handling them) - rust-lang#136985 (Do not ignore uninhabited types for function-call ABI purposes. (Remove BackendRepr::Uninhabited)) - rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround) - rust-lang#137204 (Clarify MIR dialects and phases) - rust-lang#137270 (Fix `*-win7-windows-msvc` target since 26eeac1) - rust-lang#137298 (Check signature WF when lowering MIR body) - rust-lang#137299 (Simplify `Postorder` customization.) - rust-lang#137312 (Update references to cc_detect.rs) - rust-lang#137313 (Some codegen_llvm cleanups) - rust-lang#137318 (Workaround Cranelift not yet properly supporting vectors smaller than 128bit) - rust-lang#137322 (Update docs for default features of wasm targets) - rust-lang#137324 (Make x86 QNX target name consistent with other Rust targets) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 12 pull requests Successful merges: - rust-lang#131651 (Create a generic AVR target: avr-none) - rust-lang#134340 (Stabilize `num_midpoint_signed` feature) - rust-lang#136473 (infer linker flavor by linker name if it's sufficiently specific) - rust-lang#136608 (Pass through of target features to llvm-bitcode-linker and handling them) - rust-lang#136985 (Do not ignore uninhabited types for function-call ABI purposes. (Remove BackendRepr::Uninhabited)) - rust-lang#137270 (Fix `*-win7-windows-msvc` target since 26eeac1) - rust-lang#137312 (Update references to cc_detect.rs) - rust-lang#137318 (Workaround Cranelift not yet properly supporting vectors smaller than 128bit) - rust-lang#137322 (Update docs for default features of wasm targets) - rust-lang#137324 (Make x86 QNX target name consistent with other Rust targets) - rust-lang#137338 (skip submodule updating logics on tarballs) - rust-lang#137340 (Add a notice about missing GCC sources into source tarballs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#131651 - Patryk27:avr-unknown-unknown, r=tgross35 Create a generic AVR target: avr-none This commit removes the `avr-unknown-gnu-atmega328` target and replaces it with a more generic `avr-none` variant that must be specialized using `-C target-cpu` (e.g. `-C target-cpu=atmega328p`). Seizing the day, I'm adding myself as the maintainer of this target - I've been already fixing the bugs anyway, might as well make it official 🙂 Related discussions: - rust-lang#131171 - rust-lang/compiler-team#800 try-job: x86_64-gnu-debug

…r-none` Related to: rust-lang/rust#131651 Signed-off-by: sodo <[email protected]>

rustbot assigned compiler-errors Oct 13, 2024

Patryk27 mentioned this pull request Oct 13, 2024

Remove custom target json in favour of -Ctarget-cpu? Rahix/avr-hal#586

Open

This comment has been minimized.

Sign in to view

Patryk27 force-pushed the avr-unknown-unknown branch from bdabb36 to 2639188 Compare October 13, 2024 13:25

This comment has been minimized.

Sign in to view

Patryk27 force-pushed the avr-unknown-unknown branch from 2639188 to dd8e00f Compare October 13, 2024 13:36

This comment has been minimized.

Sign in to view

workingjubilee added the O-AVR Target: AVR processors (ATtiny, ATmega, etc.) label Oct 13, 2024

jieyouxu reviewed Oct 13, 2024

View reviewed changes

src/tools/compiletest/src/header/tests.rs Outdated Show resolved Hide resolved

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024

jieyouxu approved these changes Oct 13, 2024

View reviewed changes

tgross35 reviewed Oct 14, 2024

View reviewed changes

src/doc/rustc/src/platform-support/avr-unknown-unknown.md Outdated Show resolved Hide resolved

Patryk27 mentioned this pull request Oct 14, 2024

Native support for AVR instrinsics rust-lang/compiler-builtins#711

Open

Patryk27 force-pushed the avr-unknown-unknown branch from dd8e00f to 1c8fe66 Compare October 14, 2024 13:41

This comment has been minimized.

Sign in to view

jfrimmel mentioned this pull request Oct 16, 2024

Regression test for AVR rjmp offset #131755

Merged

Patryk27 force-pushed the avr-unknown-unknown branch from 1c8fe66 to dcea80a Compare October 19, 2024 12:54

rustbot added the A-compiletest Area: The compiletest test runner label Oct 19, 2024

This comment has been minimized.

Sign in to view

avr-rjmp-offset: Explain .target_cpu()

d5128f9

tgross35 approved these changes Feb 20, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 20, 2025

workingjubilee mentioned this pull request Feb 20, 2025

Rollup of 14 pull requests #137339

Closed

workingjubilee mentioned this pull request Feb 20, 2025

Rollup of 12 pull requests #137346

Merged

bors merged commit 9de94b4 into rust-lang:master Feb 21, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Feb 21, 2025

djdisodo added a commit to djdisodo/embassy that referenced this pull request Feb 21, 2025

avr: Change ci-nightly target from avr-unknown-gnu-atmega328 to `av…

56f622f

…r-none` Related to: rust-lang/rust#131651 Signed-off-by: sodo <[email protected]>

djdisodo mentioned this pull request Feb 21, 2025

avr: Change ci-nightly target embassy-rs/embassy#3907

Draft

djdisodo added a commit to djdisodo/embassy that referenced this pull request Feb 21, 2025

avr: Change ci-nightly target from avr-unknown-gnu-atmega328 to `av…

248748d

…r-none` Related to: rust-lang/rust#131651 Signed-off-by: sodo <[email protected]>

tgross35 assigned tgross35 and unassigned compiler-errors Feb 21, 2025

Patryk27 deleted the avr-unknown-unknown branch February 23, 2025 22:29

tones111 mentioned this pull request Feb 27, 2025

AVR: linker failure - architecture of input file is incompatible #137739

Closed

joshlf mentioned this pull request Feb 27, 2025

Failing to build on certain embedded platforms google/zerocopy#2400

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a generic AVR target: avr-none #131651

Create a generic AVR target: avr-none #131651

Patryk27 commented Oct 13, 2024 •

edited by tgross35

Loading

rustbot commented Oct 13, 2024

rustbot commented Oct 13, 2024

Patryk27 commented Oct 13, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Patryk27 commented Oct 13, 2024

workingjubilee commented Oct 13, 2024

jieyouxu commented Oct 13, 2024

jieyouxu left a comment •

edited

Loading

This comment has been minimized.

This comment has been minimized.

tgross35 commented Feb 19, 2025

bors commented Feb 19, 2025

tgross35 commented Feb 19, 2025

Patryk27 commented Feb 19, 2025 •

edited

Loading

tgross35 commented Feb 19, 2025

bors commented Feb 19, 2025

Patryk27 commented Feb 20, 2025

tgross35 commented Feb 20, 2025

bors commented Feb 20, 2025

Create a generic AVR target: avr-none #131651

Create a generic AVR target: avr-none #131651

Conversation

Patryk27 commented Oct 13, 2024 • edited by tgross35 Loading

rustbot commented Oct 13, 2024

rustbot commented Oct 13, 2024

Patryk27 commented Oct 13, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Patryk27 commented Oct 13, 2024

workingjubilee commented Oct 13, 2024

jieyouxu commented Oct 13, 2024

jieyouxu left a comment • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

tgross35 commented Feb 19, 2025

bors commented Feb 19, 2025

tgross35 commented Feb 19, 2025

Patryk27 commented Feb 19, 2025 • edited Loading

tgross35 commented Feb 19, 2025

bors commented Feb 19, 2025

Patryk27 commented Feb 20, 2025

tgross35 commented Feb 20, 2025

bors commented Feb 20, 2025

Patryk27 commented Oct 13, 2024 •

edited by tgross35

Loading

jieyouxu left a comment •

edited

Loading

Patryk27 commented Feb 19, 2025 •

edited

Loading