Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler-builtins to 0.1.117 #128691

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Aug 5, 2024

This includes 1 which means we can remove the (nonworking) configuration of no-f16-f128.

Fixes #128401.

try-job: dist-various-1

r? @Amanieu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@Amanieu
Copy link
Member

Amanieu commented Aug 5, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Aug 5, 2024

📌 Commit 8c1b525 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2024
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 5, 2024
Update `compiler-builtins` to 0.1.115

This includes [1] which means we can remove the (nonworking) configuration of `no-f16-f128`.

Fixes rust-lang#128401.

[1]: rust-lang/compiler-builtins#652
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#122049 (Promote riscv64gc-unknown-linux-musl to tier 2)
 - rust-lang#125558 (Tweak type inference for `const` operands in inline asm)
 - rust-lang#128638 (run-make: enable msvc for `link-dedup`)
 - rust-lang#128647 (Enable msvc for link-args-order)
 - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`)
 - rust-lang#128656 (Enable msvc for run-make/rust-lld)
 - rust-lang#128688 (custom MIR: add support for tail calls)
 - rust-lang#128691 (Update `compiler-builtins` to 0.1.115)

r? `@ghost`
`@rustbot` modify labels: rollup
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 5, 2024

@bors r-
Maybe the cause of #128698 (comment)? It may have just been flaky but we can check.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 5, 2024

@bors try

@bors
Copy link
Contributor

bors commented Aug 5, 2024

⌛ Trying commit 8c1b525 with merge 7340af9...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2024
Update `compiler-builtins` to 0.1.115

This includes [1] which means we can remove the (nonworking) configuration of `no-f16-f128`.

Fixes rust-lang#128401.

[1]: rust-lang/compiler-builtins#652

try-job: dist-various-1
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Aug 5, 2024

💔 Test failed - checks-actions

tgross35 added a commit to tgross35/compiler-builtins that referenced this pull request Aug 5, 2024
b7af607 ("Switch to a target structure...") is checking whether the
target environment is emscripten, but it seems emscripten is the OS. Fix
this, which should resolve the issue in
<rust-lang/rust#128691 (comment)>.
@tgross35 tgross35 changed the title Update compiler-builtins to 0.1.115 Update compiler-builtins to 0.1.116 Aug 6, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 6, 2024

Changes to 0.1.116 which includes the emscripten fix from rust-lang/compiler-builtins#658. This is trivial and the change was approved at builtins:

@bors r=Amanieu

@bors
Copy link
Contributor

bors commented Aug 6, 2024

📌 Commit 3044fcf has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2024
@rust-log-analyzer

This comment has been minimized.

tgross35 added a commit to tgross35/compiler-builtins that referenced this pull request Jan 15, 2025
Replace `public_test_dep!` by placing optionally public items into new
modules, then controlling what is exported with the `public-test-deps`
feature.

This is nicer for automatic formatting and diagnostics.

This is a reland of 2e2a925 ("Eliminate the use of
`public_test_dep!`"), which was reverted in 47e50fd ('Revert "Eliminate
the use of..."') due to a bug exposed at [1]. This was fixed in [2], so
the cleanup should be able to be applied again.

[1]: rust-lang/rust#128691
[2]: rust-lang/rust#135278
tgross35 added a commit to rust-lang/compiler-builtins that referenced this pull request Jan 15, 2025
Replace `public_test_dep!` by placing optionally public items into new
modules, then controlling what is exported with the `public-test-deps`
feature.

This is nicer for automatic formatting and diagnostics.

This is a reland of 2e2a925 ("Eliminate the use of
`public_test_dep!`"), which was reverted in 47e50fd ('Revert "Eliminate
the use of..."') due to a bug exposed at [1]. This was fixed in [2], so
the cleanup should be able to be applied again.

[1]: rust-lang/rust#128691
[2]: rust-lang/rust#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 16, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 16, 2025
Update `compiler-builtins` to 0.1.144

The change between 0.1.143 and 0.1.144 includes refactoring that was in compiler-builtins before, but had to be reverted before landing in rust-lang/rust because the traits were leaking into diagnostics [1]. Recently a fix for this issue was merged [2] so the cleanup is reapplied here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2025
Update `compiler-builtins` to 0.1.144

The change between 0.1.143 and 0.1.144 includes refactoring that was in compiler-builtins before, but had to be reverted before landing in rust-lang/rust because the traits were leaking into diagnostics [1]. Recently a fix for this issue was merged [2] so the cleanup is reapplied here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2025
Update `compiler-builtins` to 0.1.144

The change between 0.1.143 and 0.1.144 includes refactoring that was in compiler-builtins before, but had to be reverted before landing in rust-lang/rust because the traits were leaking into diagnostics [1]. Recently a fix for this issue was merged [2] so the cleanup is reapplied here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2025
Update `compiler-builtins` to 0.1.144

The change between 0.1.143 and 0.1.144 includes refactoring that was in compiler-builtins before, but had to be reverted before landing in rust-lang/rust because the traits were leaking into diagnostics [1]. Recently a fix for this issue was merged [2] so the cleanup is reapplied here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
Update `compiler-builtins` to 0.1.144

The change between 0.1.143 and 0.1.144 includes refactoring that was in compiler-builtins before, but had to be reverted before landing in rust-lang/rust because the traits were leaking into diagnostics [1]. Recently a fix for this issue was merged [2] so the cleanup is reapplied here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
Update `compiler-builtins` to 0.1.144

The change between 0.1.143 and 0.1.144 includes refactoring that was in compiler-builtins before, but had to be reverted before landing in rust-lang/rust because the traits were leaking into diagnostics [1]. Recently a fix for this issue was merged [2] so the cleanup is reapplied here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278

try-job: test-various
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 28, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 28, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 28, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 28, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 29, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 29, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 29, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 29, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
rust-cloud-vms bot pushed a commit to tgross35/rust that referenced this pull request Jan 29, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
rust-cloud-vms bot pushed a commit to tgross35/rust that referenced this pull request Jan 29, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 29, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 30, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 30, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 30, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/rust that referenced this pull request Jan 30, 2025
The change between 0.1.143 and 0.1.144 includes refactoring that was in
compiler-builtins before, but had to be reverted before landing in
rust-lang/rust because the traits were leaking into diagnostics [1].
Recently a fix for this issue was merged [2] so the cleanup is reapplied
here.

This also acts as a regression test for [2].

[1]: rust-lang#128691 (comment)
[2]: rust-lang#135278
tgross35 added a commit to tgross35/compiler-builtins that referenced this pull request Feb 20, 2025
Replace `public_test_dep!` by placing optionally public items into new
modules, then controlling what is exported with the `public-test-deps`
feature.

This is nicer for automatic formatting and diagnostics.

This is a reland of 2e2a925 ("Eliminate the use of
`public_test_dep!`"), which was reverted in 47e50fd ('Revert "Eliminate
the use of..."') due to a bug exposed at [1]. This was fixed in [2], so
the cleanup should be able to be applied again.

[1]: rust-lang/rust#128691
[2]: rust-lang/rust#135278

(cherry picked from commit d4abaf4)
tgross35 added a commit to tgross35/compiler-builtins that referenced this pull request Feb 20, 2025
Replace `public_test_dep!` by placing optionally public items into new
modules, then controlling what is exported with the `public-test-deps`
feature.

This is nicer for automatic formatting and diagnostics.

This is a reland of 2e2a925 ("Eliminate the use of
`public_test_dep!`"), which was reverted in 47e50fd ('Revert "Eliminate
the use of..."') due to a bug exposed at [1]. This was fixed in [2], so
the cleanup should be able to be applied again.

[1]: rust-lang/rust#128691
[2]: rust-lang/rust#135278

(cherry picked from commit d4abaf4)
tgross35 added a commit to tgross35/compiler-builtins that referenced this pull request Feb 24, 2025
Replace `public_test_dep!` by placing optionally public items into new
modules, then controlling what is exported with the `public-test-deps`
feature.

This is nicer for automatic formatting and diagnostics.

This is a reland of 2e2a925 ("Eliminate the use of
`public_test_dep!`"), which was reverted in 47e50fd ('Revert "Eliminate
the use of..."') due to a bug exposed at [1], reapplied in d4abaf4
because the issue should have been fixed in [2], then reverted again in
f6eef07 because [2] did not actually fix the issue.

[3] has landed in rust-lang/rust since then, which should resolve the
last problem remaining after [2]. So, apply this change for what is
hopefully the final time.

[1]: rust-lang/rust#128691
[2]: rust-lang/rust#135278
[3]: rust-lang/rust#135501
tgross35 added a commit to rust-lang/compiler-builtins that referenced this pull request Feb 24, 2025
Replace `public_test_dep!` by placing optionally public items into new
modules, then controlling what is exported with the `public-test-deps`
feature.

This is nicer for automatic formatting and diagnostics.

This is a reland of 2e2a925 ("Eliminate the use of
`public_test_dep!`"), which was reverted in 47e50fd ('Revert "Eliminate
the use of..."') due to a bug exposed at [1], reapplied in d4abaf4
because the issue should have been fixed in [2], then reverted again in
f6eef07 because [2] did not actually fix the issue.

[3] has landed in rust-lang/rust since then, which should resolve the
last problem remaining after [2]. So, apply this change for what is
hopefully the final time.

[1]: rust-lang/rust#128691
[2]: rust-lang/rust#135278
[3]: rust-lang/rust#135501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression on cross compiling to aarch64-unknown-linux-musl using nightly
5 participants