Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tracing through item_bounds query invocations on opaques #126674

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 19, 2024

Previously these caused cycles when printing the result of the query.

Previously these caused cycles when printing the result
@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 19, 2024
@lqd
Copy link
Member

lqd commented Jun 19, 2024

r=me with green CI

@oli-obk
Copy link
Contributor Author

oli-obk commented Jun 19, 2024

@bors r=lqd rollup

@bors
Copy link
Contributor

bors commented Jun 19, 2024

📌 Commit 393dea8 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 19, 2024
Allow tracing through item_bounds query invocations on opaques

Previously these caused cycles when printing the result of the query.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2024
…fee1-dead

Rollup of 5 pull requests

Successful merges:

 - rust-lang#126668 (Remove now NOP attrs `#[rustc_dump{,_env}_program_clauses]`)
 - rust-lang#126674 (Allow tracing through item_bounds query invocations on opaques)
 - rust-lang#126675 (Change a `DefineOpaqueTypes::No` to `Yes` in diagnostics code)
 - rust-lang#126681 (Rework doc-test attribute documentation example)
 - rust-lang#126684 (Migrate `run-make/glibc-staticlib-args` to `rmake.rs`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cc4ace3 into rust-lang:master Jun 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2024
Rollup merge of rust-lang#126674 - oli-obk:tracing_item_bounds, r=lqd

Allow tracing through item_bounds query invocations on opaques

Previously these caused cycles when printing the result of the query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants