Fix normalization of ZST #116445
Closed
Fix normalization of ZST #116445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino |
|
This avoids an ICE, but that's just because you're dropping information on the floor. You could just replace all FnDefs with Bool and it would also stop ICEing. This PR cannot be merged with its current solution, it will just cause us problems later because now there's invalid data somewhere silently. |
Okay, will investigate more and come up with better solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we were trying to normalize aliased generic type, which caused normalization err now, we reveal all and, get type behind the alias.
Fixes rust-lang/project-stable-mir#38
r? @oli-obk