remove EvaluationResult::EvaluatedTo{Unknown,Recur} #114249
Closed
+6
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused by them while reviewing #114023.
EvaluatedToRecur
was introduced in #42840, seemingly with intent to support inductive cycles in the current solver, but that's not something we plan to have in the old solver. It is broken anyway because it's never converted intoEvaluatedToErr
in the root predicate, see the FIXME in the docs.EvaluatedToUnknown
is not handled any differently thanEvaluatedtoAmbig
.r? @lcnr @compiler-errors