Skip to content

Ensure up-to-date copyright years #9070

Closed
@lkuper

Description

@lkuper
Contributor

People don't consistently update the year in the copyright block when they edit a file. Could we either (a) just globally update them all to the latest year when the year changes (as suggested by @thestinger on IRC), or (b) if we really have to have per-file copyright granularity, have tidy check that the copyright year matches the last-modified date of the file?

Activity

thestinger

thestinger commented on Sep 9, 2013

@thestinger
Contributor

cc @brson - probably just have to ping Mozilla's legal department and see if we could handle the copyright year on a project basis rather than a file basis

As far as I know, we only have the per-file headers to avoid mistakes if someone extracts a portion of the project, and to keep it clear which files are under different licenses.

brson

brson commented on Jan 8, 2014

@brson
Contributor

I've been given advice that the entire copyright line, including the date is legally all but worthless, so it basically doesn't matter whether we keep them up to date or not. It was suggested that we continue to do it on a best-effort basis and not sweat it, though I guess that's not too satisfying since putting any effort into something useless is kinda silly.

brson

brson commented on Jan 8, 2014

@brson
Contributor

Having them be inconsistent also just rubs one the wrong way too. If anyone feel strongly we should add some automation here we can still consider it.

ahmedcharles

ahmedcharles commented on May 28, 2014

@ahmedcharles
Contributor

Just curious, where's the check code that runs during the build to verify line lengths? That's probably easy to update to check the header of each file?

brson

brson commented on May 28, 2014

@brson
Contributor

@ahmedcharles src/etc/tidy.py and src/etc/licenseck.py

added a commit that references this issue on Jan 21, 2015
718badb
frewsxcv

frewsxcv commented on Feb 2, 2015

@frewsxcv
Member

/cc @gerv since he was consulted in #21481

IANAL, but realistically I wouldn't think there's much of a difference if the year in the header is off by a couple years.

gerv

gerv commented on Feb 2, 2015

@gerv

The policy I recommend is:

  • Don't bother to update them
  • If someone does update them in a patch, ignore it (i.e. accept the patch without comment)

The actual copyright status of the file is unaffected by what it says at the top, so people for whom it's actually important when the copyright expires (i.e. no-one) will have to do more research in any case.

frewsxcv

frewsxcv commented on Feb 2, 2015

@frewsxcv
Member

@gerv Sounds very sane in my opinion. Given that response, this can be closed?

lkuper

lkuper commented on Feb 2, 2015

@lkuper
ContributorAuthor

Yeah, since filing this bug over a year ago I came to realize (from working on another project) that the dates in the files really don't matter. I also think it can be closed.

alexcrichton

alexcrichton commented on Feb 2, 2015

@alexcrichton
Member

Ok, thanks for the info @gerv!

9 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @alexcrichton@brson@gerv@frewsxcv@lkuper

      Issue actions

        Ensure up-to-date copyright years · Issue #9070 · rust-lang/rust