Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FloatToInit docs incorrect symbol: round_unchecked_to - should be to_int_unchecked #82709

Closed
peter-lyons-kehl opened this issue Mar 2, 2021 · 1 comment
Closed

FloatToInit docs incorrect symbol: round_unchecked_to - should be to_int_unchecked #82709

peter-lyons-kehl opened this issue Mar 2, 2021 · 1 comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@peter-lyons-kehl
Copy link
Contributor

https://doc.rust-lang.org/nightly/std/convert/trait.FloatToInt.html mentions a non-existing symbol: round_unchecked_to. The correct one is: to_int_unchecked. (There is no word round anywhere in library/core/src/convert/num.rs.)

Notes

  • Even though this is a Docs defect, I'm not mentioning steveklabnik, since I don't believe this needs his attention.
  • based on my grep search, the current master doesn't refer to the incorrect reference anywhere else.
  • I'll provide a PR.
@peter-lyons-kehl peter-lyons-kehl added the C-bug Category: This is a bug. label Mar 2, 2021
peter-lyons-kehl added a commit to peter-lyons-kehl/rust that referenced this issue Mar 2, 2021
@peter-lyons-kehl
FloatToInit: Replacing round_unchecked_to --> to_int_unchecked
d4763da 
FloatToInit docs: Replacing round_unchecked_to with
to_int_unchecked. Bug rust-lang#82709.
@peter-lyons-kehl peter-lyons-kehl mentioned this issue Mar 2, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Mar 2, 2021
@Dylan-DPC
Rollup merge of rust-lang#82710 - peter-kehl:FloatToInit_82709, r=sfa…
cddd8f2 
…ckler

FloatToInit: Replacing round_unchecked_to --> to_int_unchecked

FloatToInit docs: Replacing round_unchecked_to with
to_int_unchecked. Bug rust-lang#82709.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Mar 3, 2021
@JohnTitor
Rollup merge of rust-lang#82710 - peter-kehl:FloatToInit_82709, r=sfa…
376655e 
…ckler

FloatToInit: Replacing round_unchecked_to --> to_int_unchecked

FloatToInit docs: Replacing round_unchecked_to with
to_int_unchecked. Bug rust-lang#82709.
@JohnTitor JohnTitor added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 3, 2021
@JohnTitor
Copy link
Member

Fixed by #82710.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peter-lyons-kehl @JohnTitor